Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/527#issuecomment-115289744
Hi @bhaisaab
No, it doesn't change pwd in the hosts. I will implement that in a separate
story/issue.
Concerning the squash, I won't do it. Why? The commits are atomic, which
makes easier to review (e.g. one doesn't need t review commits that say
"formatting code..."). I split code formatting from the fixes. Another point,
if there is a change in a given commit, I will change just that commit and push
it, which reduces the work for the person behind the fixes as well. On a third
point, if we squash atomic commits, the reviewer will have the whole huge thing
to look at, as everything has just be done together.
In short, squashing those atomic commits will bring no benefit at all.
Squash would only help if someone messes up with the commits and have
everything tangled, which is not the case with this PR.
If you look at the bullet point on the PR description, those are the most
relevant commits to look at. I even took care of using the same commit title
for the bullet points.
I will start testing this evening.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
