Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/476#discussion_r32721772
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -926,7 +926,7 @@ protected void checkIfPodIsDeletable(final long podId) {
dbName = "cloud";
}
- String selectSql = "SELECT * FROM `" + dbName + "`.`" +
tableName + "` WHERE " + column + " = ?";
+ String selectSql = "SELECT * FROM `?`.`?` WHERE ? = ?";
if(tableName.equals("vm_instance")) {
selectSql += " AND state != '" +
VirtualMachine.State.Expunging.toString() + "' AND removed IS NULL";
--- End diff --
wondering why are we even using a prepareStatement here (and doing a fix to
satisfy findbugs). Why dont we use createStatement() and execute sql directly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
