The specific comment Marcus made was warning - but it was/is already commited in 4.5.1 vanila. But it doesnt work as it seems...
Even qemu-img resize worked fine for me on poweredoff VMs/volumes mutiply times (with DB changes), and later we fix manually partitions/FS inside OS. But here also live resize works, on powered on VM - virsh # vol-info --pool 8457c284-cf5d-3979-b82e-32ea5efeb97b cold-storage/fe51d252-e12b-4dae-86b1-fcc897ebbe23 Name: fe51d252-e12b-4dae-86b1-fcc897ebbe23 Type: network Capacity: 10.00 GiB Allocation: 10.00 GiB virsh # vol-resize --pool 8457c284-cf5d-3979-b82e-32ea5efeb97b cold-storage/fe51d252-e12b-4dae-86b1-fcc897ebbe23 20G Size of volume 'fe51d252-e12b-4dae-86b1-fcc897ebbe23' successfully changed to 20G virsh # vol-info --pool 8457c284-cf5d-3979-b82e-32ea5efeb97b cold-storage/fe51d252-e12b-4dae-86b1-fcc897ebbe23 Name: fe51d252-e12b-4dae-86b1-fcc897ebbe23 Type: network Capacity: 20.00 GiB Allocation: 20.00 GiB virsh # blockresize --path vdb --size 20G i-2-9-VM Block device 'vdb' is resized Checked inside VM, all fine, and fsck -f /dev/vdb1 gives no errors... On 28 May 2015 at 17:21, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > Marcus reported corrupted volumes due to this, in the pr: > https://github.com/apache/cloudstack/pull/281#issuecomment-104432629 > I am not sure it was due to this code or that it didn't get solved by this > code. As it is in 4.5 and master I will leave it in for now. meaning in > 4.4.4. > > Op do 28 mei 2015 om 17:12 schreef Andrija Panic <andrija.pa...@gmail.com > >: > > > Not really, volume is still fine (undamaged) :) but resize doesnt work, > > seems like code-only issue, since on debug agent in logs, I dont see > > anything sent to libvirt etc...confirmed from inside VM. > > > > On 28 May 2015 at 16:58, Daan Hoogland <daan.hoogl...@gmail.com> wrote: > > > > > yes, that one is. It doesn't solve the problem, I understand. Does it > > > worsen it? > > > > > > Op do 28 mei 2015 om 16:56 schreef Andrija Panic < > > andrija.pa...@gmail.com > > > >: > > > > > > > Ah...sorry for that, my bad... I understood it's already present on > > 4.5.1 > > > > vanial.. > > > > But I understood that this commit IS actually already present in > 4.5.1: > > > > > > > > > > > > > > https://github.com/apache/cloudstack/commit/173909e99d85cfcc85b017bc426950f9f16fddf0 > > > > ? > > > > > > > > > > > > > > > > On 28 May 2015 at 16:33, Daan Hoogland <daan.hoogl...@gmail.com> > > wrote: > > > > > > > > > Andrija, the code you refer to is post-4.5. it is not in 4.4 or > > 4.5.So > > > I > > > > > am > > > > > a bit confused by your remark. > > > > > How do you mean it generates the error you got? > > > > > Did you apply the patch from PR-281 on 4.5.1 and tested? > > > > > or did you test a vanilla 4.5.1? > > > > > > > > > > Op do 28 mei 2015 om 16:22 schreef Andrija Panic < > > > > andrija.pa...@gmail.com > > > > > >: > > > > > > > > > > > Daan - I just tested this (but on 4.5.1), and it doesnt work, at > > > least > > > > in > > > > > > my setup: > > > > > > > > > > > > 2015-05-28 16:14:56,108 DEBUG [kvm.storage.LibvirtStorageAdaptor] > > > > > > (agentRequest-Handler-1:null) Trying to fetch storage pool > > > > > > 8457c284-cf5d-3979-b82e-32ea5efeb97b from libvirt > > > > > > 2015-05-28 16:14:56,257 DEBUG > > [kvm.resource.LibvirtComputingResource] > > > > > > (agentRequest-Handler-1:null) Failed to resize volume: Cannot > > > determine > > > > > > resize type from pool type RBD > > > > > > 2015-05-28 16:14:56,257 DEBUG [cloud.agent.Agent] > > > > > > (agentRequest-Handler-1:null) Seq 1-4646870390516222369: { Ans: > , > > > > > MgmtId: > > > > > > 90520740254323, via: 1, Ver: v1, Flags: 10, > > > > > > > > > > > > > > > > > > > > > > > > > > > [{"com.cloud.agent.api.storage.ResizeVolumeAnswer":{"newSize":0,"result":false,"details":"Failed > > > > > > to resize volume: Cannot determine resize type from pool type > > > > > > RBD","wait":0}}] } > > > > > > > > > > > > This is from agent logs, and same messages in management logs. > > > > > > No logs in libvirt.log > > > > > > > > > > > > Found some interesting code here, that generates the error I got > - > > > > > > > > > > > > > > > > > > > > > > > > > > > http://mail-archives.apache.org/mod_mbox/cloudstack-commits/201505.mbox/%3c5917de61cbfc41a59e68f25cd7e79...@git.apache.org%3E > > > > > > We are using Ubuntu 14.04, ACS 4.5.1, defautl versions of libvirt > > > > etc... > > > > > > > > > > > > Regards, > > > > > > Andrija > > > > > > > > > > > > > > > > > > On 22 May 2015 at 09:42, Daan Hoogland <daan.hoogl...@gmail.com> > > > > wrote: > > > > > > > > > > > > > Andrija, I am holding this one because of comments Marcus made > in > > > the > > > > > > pull > > > > > > > request. > > > > > > > > > > > > > > Op vr 22 mei 2015 om 09:39 schreef Daan Hoogland < > > > > > > daan.hoogl...@gmail.com > > > > > > > >: > > > > > > > > > > > > > > > same fork -create pr procedure > > > > > > > > > > > > > > > > Op do 21 mei 2015 om 18:29 schreef Andrija Panic < > > > > > > > andrija.pa...@gmail.com > > > > > > > > >: > > > > > > > > > > > > > > > > Daan, I'm not so sure I can pull this in short time frame - > I'm > > > no > > > > > > > >> developer at all :( > > > > > > > >> > > > > > > > >> Any guidelines for dummies? something via github clone etc > (I > > > did > > > > > that > > > > > > > for > > > > > > > >> documenation ) ? > > > > > > > >> > > > > > > > >> thx > > > > > > > >> > > > > > > > >> On 21 May 2015 at 18:11, Daan Hoogland < > > daan.hoogl...@gmail.com > > > > > > > > > > wrote: > > > > > > > >> > > > > > > > >> > Andrija, can you backport and make a pull request? > > > > > > > >> > > > > > > > > >> > Op do 21 mei 2015 om 17:41 schreef Andrija Panic < > > > > > > > >> andrija.pa...@gmail.com > > > > > > > >> > >: > > > > > > > >> > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=173909e99d85cfcc85b017bc426950f9f16fddf0 > > > > > > > >> > > > > > > > > > >> > > enable CEPH image resize if possible :) > > > > > > > >> > > > > > > > > > >> > > On 21 May 2015 at 08:42, Daan Hoogland < > > > > daan.hoogl...@gmail.com > > > > > > > > > > > > > >> wrote: > > > > > > > >> > > > > > > > > > >> > > > H, > > > > > > > >> > > > > > > > > > > >> > > > Are there any fixes that people have that should go > into > > > > 4.4? > > > > > I > > > > > > > >> would > > > > > > > >> > > like > > > > > > > >> > > > to create a release candidate over the weekend. > > > > > > > >> > > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > > > > > > > > >> > > -- > > > > > > > >> > > > > > > > > > >> > > Andrija Panić > > > > > > > >> > > > > > > > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> -- > > > > > > > >> > > > > > > > >> Andrija Panić > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > > > Andrija Panić > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Andrija Panić > > > > > > > > > > > > > > > -- > > > > Andrija Panić > > > -- Andrija Panić
