GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/255
Fixing the testGetHostStatsCommand test under LibvirtComputingResourceTest
- Removed the expected value from the Test annotation
- Mocking the bash path in order to avoid environment/OS issues
Fixing typo on LibvirtRequestWrapper
- Replace linbvirtCommands by libvirtCommands on LibvirtRequestWrapper
@DaanHoogland @bhaisaab @karuturi @kishankavala
This PR contains a fix for the Unit Test. I'm mocking the path so it will
not fail if the machine where the test is running contains garbage on a given
directory
@kishankavala, it has been again tested and a KVM datacenter can be easily
deployed. Please, before testing it, make sure you do a full build of the
source.
Cheers,
Wilder
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack
fix/libvirt_unit_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #255
----
commit 4f62e582eee7f7ab0b7b576a98bc1a42adf95d76
Author: wilderrodrigues <[email protected]>
Date: 2015-05-18T12:30:36Z
Fixing the testGetHostStatsCommand test under LibvirtComputingResourceTest.
- Removed the expected value from the Test annotation
- Mocking the bash path in order to avoid environment/OS issues
Fixing typo on LibvirtRequestWrapper
- Replace linbvirtCommands by libvirtCommands on LibvirtRequestWrapper
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
