Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/167#issuecomment-93206684
  
    If the router is restarted from ACS management server, yes, it will apply 
all setting. However, if one connects to the router and reboots it - or the 
router crashes - all configuration is gone and a restart from acs will be 
needed.
    
    But I agree that cherry picking thousands os lines of code - due to new 
pythons code, shell and a huge java refactor, is too risky.
    
    Cheers,
    Wilder
    
    Sent from my iPhone
    
    On 15 Apr 2015, at 07:54, Rohit Yadav 
<notificati...@github.com<mailto:notificati...@github.com>> wrote:
    
    
    @resmo<https://github.com/resmo> 
@wilderrodrigues<https://github.com/wilderrodrigues> I would avoid 
cherry-picking this feature on 4.5; AFAIK if a router reboots, cloudstack 
should re-apply any iptables rules and patch it again using systemvm.iso. We 
can do it you need this improvement in 4.5, but then that will require 
exhaustive testing to make sure we won't be breaking stuff.
    
    —
    Reply to this email directly or view it on 
GitHub<https://github.com/apache/cloudstack/pull/167#issuecomment-93206215>.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to