----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24308/#review79036 -----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Aug. 6, 2014, 4:58 a.m., Damodar Reddy Talakanti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24308/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 4:58 a.m.) > > > Review request for cloudstack and Darren Shepherd. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-7249 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-7249 > > > Repository: cloudstack-git > > > Description > ------- > > Currently Cloudstack will not return any parameter related to password > strength during account/user creation. This patch will try to enable this for > the end user while setting his password to know the strength of his password. > > The FS link for this enhancement is at : > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Password+Strength+Checker+For+a+User > > > Diffs > ----- > > api/src/com/cloud/user/User.java 36e9028 > api/src/com/cloud/user/UserAccount.java c5a0637 > api/src/org/apache/cloudstack/api/response/AccountResponse.java 2e50c51 > api/src/org/apache/cloudstack/api/response/UserResponse.java 40e1561 > client/pom.xml fcd8317 > > core/resources/META-INF/cloudstack/core/spring-core-lifecycle-core-context-inheritable.xml > 515249d > > core/resources/META-INF/cloudstack/core/spring-core-registry-core-context.xml > 02034d6 > engine/schema/src/com/cloud/user/UserAccountVO.java cef9239 > engine/schema/src/com/cloud/user/UserVO.java 8ab450d > plugins/pom.xml b3890c0 > plugins/security/password-checker/pom.xml PRE-CREATION > > plugins/security/password-checker/resources/META-INF/cloudstack/password-checker/module.properties > PRE-CREATION > > plugins/security/password-checker/resources/META-INF/cloudstack/password-checker/spring-password-checker-context.xml > PRE-CREATION > plugins/security/password-checker/resources/password-checker.properties > PRE-CREATION > > plugins/security/password-checker/src/org/apache/cloudstack/security/password/PasswordCheckerImpl.java > PRE-CREATION > > plugins/security/password-checker/test/org/apache/cloudstack/security/password/PasswordCheckerTest.java > PRE-CREATION > > plugins/security/password-checker/test/org/apache/cloudstack/security/password/PasswordCheckerTest2.java > PRE-CREATION > > plugins/security/password-checker/test/resources/password-checker2.properties > PRE-CREATION > plugins/security/password-checker/test/resources/passwordChecker2.xml > PRE-CREATION > > plugins/security/password-checker/test/resources/spring-password-checker-context.xml > PRE-CREATION > > plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapAuthenticator.java > afba272 > > plugins/user-authenticators/md5/resources/META-INF/cloudstack/md5/spring-md5-context.xml > 4a8e64d > > plugins/user-authenticators/md5/src/com/cloud/server/auth/MD5UserAuthenticator.java > d478df6 > > plugins/user-authenticators/md5/test/com/cloud/server/auth/MD5UserAuthenticatorTest.java > a0189e1 > > plugins/user-authenticators/plain-text/resources/META-INF/cloudstack/plaintext/spring-plaintext-context.xml > 639411a > > plugins/user-authenticators/plain-text/src/com/cloud/server/auth/PlainTextUserAuthenticator.java > 0afbbfc > > plugins/user-authenticators/sha256salted/resources/META-INF/cloudstack/sha256salted/spring-sha256salted-context.xml > e379718 > > plugins/user-authenticators/sha256salted/src/com/cloud/server/auth/SHA256SaltedUserAuthenticator.java > 36305f1 > > plugins/user-authenticators/sha256salted/test/src/com/cloud/server/auth/test/AuthenticatorTest.java > 0a9bd2f > pom.xml 2186f83 > server/src/com/cloud/api/ApiResponseHelper.java 221e266 > server/src/com/cloud/server/ManagementServerImpl.java 7b5422e > server/src/com/cloud/server/auth/DefaultUserAuthenticator.java ea8e87b > server/src/com/cloud/server/auth/Password.java PRE-CREATION > server/src/com/cloud/server/auth/UserAuthenticator.java 895c3c0 > server/src/com/cloud/user/AccountManagerImpl.java 11876fa > server/src/org/apache/cloudstack/security/password/PasswordChecker.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/24308/diff/ > > > Testing > ------- > > Tested on the master branch. Tested the following scenarios > > 1. Enable the password checker > 2. Enable the password enforce > 3. Not enabled both above parameters. > 4. Not putting the plugin into the deployment. > > > Thanks, > > Damodar Reddy Talakanti > >
