----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25266/#review79025 -----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Sept. 19, 2014, 7:17 p.m., Rayees Namathponnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25266/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2014, 7:17 p.m.) > > > Review request for cloudstack, Frank Zhang and Hugo Trippaers. > > > Bugs: CLOUDSTACK-7469 > https://issues.apache.org/jira/browse/CLOUDSTACK-7469 > > > Repository: cloudstack-git > > > Description > ------- > > Currently there is no option to build rpm with simulator, as part this patch > modified package.sh file to accept simulator > > also updated cloud.spec file to build both oss and nooss simulator buids > > > To build noredist and simulator, you need to use below package command > ./package.sh --pack noredist --s simulator > > default package with simulato, need to call ./package.sh > > > Diffs > ----- > > packaging/centos63/cloud.spec 7306d1f > packaging/centos63/package.sh 6a2d168 > > Diff: https://reviews.apache.org/r/25266/diff/ > > > Testing > ------- > > Yes > > > File Attachments > ---------------- > > 0001-Simulator-build-support-for-RPM-builds.patch > > https://reviews.apache.org/media/uploaded/files/2014/09/19/2537284e-f1de-419a-b5b6-66b8ddfcac84__0001-Simulator-build-support-for-RPM-builds.patch > > > Thanks, > > Rayees Namathponnan > >
