----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28573/#review79007 -----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board. We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted). Please consider submitting a pull request. Great instructions are available at: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more. - Sebastien Goasguen On Dec. 1, 2014, 8:48 p.m., Silvano Buback wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28573/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 8:48 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > JIRA: CLOUDSTACK-7995 > > Design document: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Regular+cloudstack+user+can+create+and+manage+shared+networks+by+GloboNetwork+in+a+simpler+way > > Base commit (in master): 4798db0de1862bbdf7f2af67f7684f2f3430609e > > > Diffs > ----- > > api/src/com/cloud/network/Network.java c5a9bf2 > api/src/org/apache/cloudstack/api/ApiConstants.java 762ad70 > api/src/org/apache/cloudstack/api/response/NetworkResponse.java 40c9072 > api/src/org/apache/cloudstack/network/ExternalNetworkDeviceManager.java > b349356 > client/pom.xml 6803f9a > client/tomcatconf/commands.properties.in a87d167 > plugins/network-elements/globonetwork/LICENSE PRE-CREATION > plugins/network-elements/globonetwork/NOTICE PRE-CREATION > plugins/network-elements/globonetwork/pom.xml PRE-CREATION > > plugins/network-elements/globonetwork/resources/META-INF/cloudstack/globonetwork/module.properties > PRE-CREATION > > plugins/network-elements/globonetwork/resources/META-INF/cloudstack/globonetwork/spring-globonetwork-context.xml > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/GloboNetworkEnvironmentVO.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/GloboNetworkNetworkVO.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/GloboNetworkVipAccVO.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/AddGloboNetworkEnvironmentCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/AddGloboNetworkHostCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/AddNetworkViaGloboNetworkCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/DeleteNetworkInGloboNetworkCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/GloboNetworkCapabilitiesResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/GloboNetworkEnvironmentResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/ListAllEnvironmentsFromGloboNetworkCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/ListGloboNetworkCapabilitiesCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/ListGloboNetworkEnvironmentsCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/api/RemoveGloboNetworkEnvironmentCmd.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/ActivateNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/CreateNewVlanInGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/DeallocateVlanFromGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/GetVlanInfoFromGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/GloboNetworkErrorAnswer.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/ListAllEnvironmentsFromGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/RegisterEquipmentAndIpInGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/RemoveNetworkInGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/UnregisterEquipmentAndIpInGloboNetworkCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/commands/ValidateNicInVlanCommand.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/dao/GloboNetworkEnvironmentDao.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/dao/GloboNetworkEnvironmentDaoImpl.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/dao/GloboNetworkNetworkDao.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/dao/GloboNetworkNetworkDaoImpl.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/element/GloboNetworkElement.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/exception/CloudstackGloboNetworkException.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/guru/GloboNetworkGuru.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/manager/GloboNetworkManager.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/manager/GloboNetworkService.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/resource/GloboNetworkResource.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/response/GloboNetworkAllEnvironmentResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/response/GloboNetworkEnvironmentExternalResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/response/GloboNetworkVipResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/src/com/globo/globonetwork/cloudstack/response/GloboNetworkVlanResponse.java > PRE-CREATION > > plugins/network-elements/globonetwork/test/com/globo/globonetwork/cloudstack/guru/GloboNetworkGuruTest.java > PRE-CREATION > > plugins/network-elements/globonetwork/test/com/globo/globonetwork/cloudstack/manager/GloboNetworkManagerTest.java > PRE-CREATION > > plugins/network-elements/globonetwork/test/com/globo/globonetwork/cloudstack/resource/GloboNetworkResourceTest.java > PRE-CREATION > plugins/network-elements/globonetwork/test/resources/db.properties > PRE-CREATION > plugins/network-elements/globonetwork/test/resources/log4j.properties > PRE-CREATION > plugins/pom.xml 76119dc > server/src/com/cloud/api/ApiResponseHelper.java f4be820 > setup/db/db/schema-450to460.sql 8480c85 > ui/index.jsp 5ba6301 > ui/scripts/globonetwork.js PRE-CREATION > ui/scripts/network.js c31ba76 > ui/scripts/sharedFunctions.js b148ded > ui/scripts/system.js b6a35a3 > > Diff: https://reviews.apache.org/r/28573/diff/ > > > Testing > ------- > > Few unit tests to guarantee proper usage of Manager and Guru in GloboNetwork > plugin. > > All Cloudstack unit tests executed successfully. > > Launched Cloudstack, configured plugin and added/removed networks and > instances through GloboNetwork plugin. > > > Thanks, > > Silvano Buback > >
