GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/142
Bump priority stragety is no longer used for redundant virtual routers
- With the changes added by the rVPC work, the bump priority became
deprecated.
This commit includes a refactor to get it removed from the following
resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
Test Create Account and user for that account ... === TestName:
test_01_create_account | Status : SUCCESS ===
ok
Test Sub domain allowed to launch VM when a Domain level zone is created
... === TestName: test_01_add_vm_to_subdomain | Status : SUCCESS ===
ok
Test delete domain without force option ... === TestName: test_DeleteDomain
| Status : SUCCESS ===
ok
Test delete domain with force option ... === TestName:
test_forceDeleteDomain | Status : SUCCESS ===
ok
Test update admin details ... === TestName: test_updateAdminDetails |
Status : SUCCESS ===
ok
Test update domain admin details ... === TestName:
test_updateDomainAdminDetails | Status : SUCCESS ===
ok
Test user update API ... === TestName: test_updateUserDetails | Status :
SUCCESS ===
ok
Test login API with domain ... === TestName: test_LoginApiDomain | Status :
SUCCESS ===
ok
Test if Login API does not return UUID's ... === TestName:
test_LoginApiUuidResponse | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 9 tests in 1165.016s
OK
/tmp//MarvinLogs/test_accounts_7Q4OAG/results.txt (END)
Test router internal advanced zone ... SKIP: Marvin configuration has no
host credentials to check router services
Test restart network ... === TestName: test_03_restart_network_cleanup |
Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status :
SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced |
Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS
===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS
===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status :
SUCCESS ===
ok
----------------------------------------------------------------------
Ran 7 tests in 438.824s
OK (SKIP=1)
/tmp//MarvinLogs/test_routers_IYY39F/results.txt (END)
Test advanced zone virtual router ... === TestName:
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status :
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName:
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status :
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status :
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status :
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm
| Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 896.406s
OK (SKIP=1)
/tmp//MarvinLogs/test_vm_life_cycle_YMQT53/results.txt (END)
Test migrate of router after addition of one guest network ... SKIP: No
host available for migration. Test requires atleast 2 hosts
Test to change service offering of router after addition of one guest
network ... === TestName:
test_07_chg_srv_off_router_after_addition_of_one_guest_network | Status :
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... ===
TestName: test_08_destroy_router_after_addition_of_one_guest_network | Status :
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName:
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName:
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Test migration of router to another host after creating VPC ... SKIP: No
host available for migration. Test requires atleast 2 hosts
Tests to change service offering of the Router after ... === TestName:
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName:
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 658.661s
OK (SKIP=2)
/tmp//MarvinLogs/test_redundant_vpc_B8W8PF/results.txt (END)
Test to create service offering ... === TestName:
test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName:
test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName:
test_03_delete_service_offering | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 3 tests in 257.889s
OK
/tmp//MarvinLogs/test_service_offerings_XQKSQK/results.txt (END)
Test start/stop of router after addition of one guest network ... ===
TestName: test_01_start_stop_router_after_addition_of_one_guest_network |
Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName:
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest
network ... === TestName:
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status :
SUCCESS ===
ok
Test destroy of router after addition of one guest network ... ===
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status :
SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName:
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName:
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName:
test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName:
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 843.583s
OK
/tmp//MarvinLogs/test_vpc_routers_U0K0B9/results.txt (END)
Test create VPC offering ... === TestName: test_01_create_vpc_offering |
Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName:
test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName:
test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName:
test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName:
test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status
: SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status :
SUCCESS ===
ok
test_09_create_redundant_vpc_offering
(integration.acs.tests.test_vpc_offerings.TestVPCOffering) ... === TestName:
test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 8 tests in 676.956s
OK
/tmp//MarvinLogs/test_vpc_offerings_0M441V/results.txt (END)
test_privategw_acl
(integration.acs.tests.test_privategw_acl.TestPrivateGwACL) ... === TestName:
test_privategw_acl | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 100.801s
OK
/tmp//MarvinLogs/test_privategw_acl_3R9O5I/results.txt (END)
Test VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status :
SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS
===
ok
----------------------------------------------------------------------
Ran 2 tests in 395.555s
OK
/tmp//MarvinLogs/test_vpc_vpn_P94PXY/results.txt (END)
Test reset virtual machine on reboot ... === TestName:
test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 227.783s
OK
/tmp//MarvinLogs/test_reset_vm_on_reboot_YUAXBK/results.txt (END)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack
refactor/bump_priority-REBASE
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit 3d22a16c4fb41e845edfc4294e7ce8c00f36c89e
Author: wilderrodrigues <[email protected]>
Date: 2015-04-02T16:20:29Z
Bump priority stragety is no longer used for redundant virtual routers
- With the changes added by the rVPC work, the bump priority became
deprecated.
This commit includes a refactor to get it removed from the following
resources:
* Java classes
* domain_router table - removing the is_priority_bumpup column
* Fixing unit tests
All changes were tested with:
XenServer 6.2 running under our VMWare zone
CloudStack Management Server running on MacBook Pro
MySql running on MackBook Pro
Storage Type: Local
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
