/me not being smart enough to use pull requests. I am pulling it now.
On Fri, Mar 27, 2015 at 12:04 PM, Funs Kessen <f...@barred.org> wrote: > Hi Daan, > >> On 27 Mar 2015, at 11:58, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >> >> Funs, I commented on it, I think it has a typo in it. >> Roger, can you apply that patch and test (after looking at my comment)? > > I replied to you, that’s why the pull request contains two commit IDs ;) > >> >> On Fri, Mar 27, 2015 at 11:33 AM, Funs Kessen <f...@barred.org> wrote: >>> Hi Daan, >>> >>> Had a fix ready yesterday, but after having slept on it, I crushed the fix >>> as it was wrong. I’ve fixed it by setting the separator hard, and not to >>> File.separator. >>> >>> The logic behind is that the Agent runs on Linux and not on Windows so >>> using File.separator will just break things instead of making it work, as >>> the code should not be platform independent but specifically for the Agent. >>> >>> I’ve got pull request #133 open which should resolve the issues on Windows. >>> >>> Cheers, >>> >>> Funs >>> >>>> On 26 Mar 2015, at 21:53, Funs Kessen <f...@barred.org> wrote: >>>> >>>> >>>>> On 26 Mar 2015, at 21:41, Daan Hoogland <daan.hoogl...@gmail.com> wrote: >>>>> >>>>> On Thu, Mar 26, 2015 at 9:35 PM, Funs Kessen <f...@barred.org> wrote: >>>>>> Hi Roger/Daan, >>>>>> >>>>>> Sorry for coming late to the party, and my apologies in advance! >>>>> >>>>> that's alright, i learned something about cs;) >>>>> >>>> Ditto!! :) >>>> >>>>> ... >>>>>> The second part of the booboo is in the tests themselves actually as >>>>>> you’ve noticed, so I’ll have to place the File.seperator there too in >>>>>> XenTest.java. >>>>>> >>>>>> Thanks for reaching out! >>>>>> >>>>>> @Daan: I can fix it in the ovm3rebase branch so you can pick it out ? >>>>> >>>>> yeah, that or send me a patch >>>>> >>>> I’ll get you a patch asap, want to make sure I don’t have to make two =) >>>> >>>>> Don't forget I added to the misery myself by adding >>>>> a4c23b170e4c94d4ed4783b19a051ad8f6c45328 >>>>> >>>> "My friend of misery" ? >>>> >>>> — >>>> =Funs >>> >>> — >>> =Funs >>> >> >> >> >> -- >> Daan >> > > — > =Funs > -- Daan
