----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30553/#review77529 -----------------------------------------------------------
test/integration/component/test_escalations_hosts.py <https://reviews.apache.org/r/30553/#comment125630> It's better to have the method definitions outside of the class so it may be used later for the entire suite. test/integration/component/test_escalations_hosts.py <https://reviews.apache.org/r/30553/#comment125631> host_state is not used. Can be removed from both definition and invocation test/integration/component/test_escalations_hosts.py <https://reviews.apache.org/r/30553/#comment125633> host_state not used here as well. Can be removed test/integration/component/test_escalations_hosts.py <https://reviews.apache.org/r/30553/#comment125635> host_state can be removed here too test/integration/component/test_escalations_hosts.py <https://reviews.apache.org/r/30553/#comment125637> These tests can be run without hardware as well I presume. If you think so, can you change this? - Sowmya Krishnan On Feb. 3, 2015, 12:25 p.m., abhinav roy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30553/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2015, 12:25 p.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Repository: cloudstack-git > > > Description > ------- > > This Patch has following changes : > > 1. A new script to test host status after enabling/disabling of Pods, > Clusters, Zones or by managing/unmanaging of clusters etc. > > 2. "update" Modules added for Pod, Zone, cluster classes in base.py > > > Diffs > ----- > > test/integration/component/test_escalations_hosts.py PRE-CREATION > > Diff: https://reviews.apache.org/r/30553/diff/ > > > Testing > ------- > > Disable the host and it's cluster, ... === TestName: > test_01_op_host_capacity_disable_cluster | Status : SUCCESS === > ok > Disable the host and it's pod, ... === TestName: > test_02_op_host_capacity_disable_pod | Status : SUCCESS === > ok > Disable the host and it's zone, ... === TestName: > test_03_op_host_capacity_disable_zone | Status : SUCCESS === > ok > Disable the host then unmanage the cluster, ... === TestName: > test_04_disable_host_unmanage_cluster_check_hosts_status | Status : SUCCESS > === > ok > > ---------------------------------------------------------------------- > Ran 4 tests in 126.360s > > > Thanks, > > abhinav roy > >
