I patched this on our production systems in another way but forgot to give it back. I think this is the way it should be done in our API design, isn't it?
@Rohit: can you review the enclosed patch? On Fri, Mar 6, 2015 at 5:52 PM, Rajani Karuturi <raj...@apache.org> wrote: > I think this pull request[1] and cloudstack-8280 are related or same as > this issue. > > https://github.com/apache/cloudstack/pull/87 > > Do not have access to laptop right now. Just posting from the reviews I did > last week on the pending PRs. > > > On Fri, Mar 6, 2015 at 21:54 PM, Rohit Yadav <rohit.ya...@shapeblue.com> > wrote: > > Hi Andrija, > > Don't worry, it's not a blocker in the sense that will take down your > cloud :) I've tried to fix it now, testing it. > > On Friday 06 March 2015 08:21 PM, Andrija Panic wrote: > >> >> Hi, >> I'm not DEV - but please don't release it with such a big blocker - Im >> using VPC extensively,and all our customers - it's simply doesnt make sense >> to release with such a blocker... >> >> best >> >> >> On 6 March 2015 at 15:42, Geoff Higginbottom < >> geoff.higginbot...@shapeblue.com> wrote: >> >> >>> Hi Pierre, >>> >>> This issue effectively removes the control for users to review their >>> existing VPC ACL rules, and whilst you can add new, you have no idea what >>> the settings are with respect to the CIDR after you have added it. >>> >>> This bug affects the API and UI, always returning a blank CIDR list. >>> >>> Given the problems with the 4.4.0 release, we do not want to release >>> another new version with a known bug that was detected during the RC >>> process but unfortunately not fixed. >>> >>> Regards >>> >>> Geoff Higginbottom >>> >>> D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581 >>> >>> geoff.higginbot...@shapeblue.com >>> >>> -----Original Message----- >>> From: Pierre-Luc Dion [mailto:pd...@cloudops.com] >>> Sent: 06 March 2015 14:32 >>> To: dev@cloudstack.apache.org >>> Subject: Re: [RESULT] [VOTE] Apache CloudStack 4.5.0 RC4 >>> >>> Can we release 4.5.0, and see how it could be fixed in 4.5.1 ? >>> >>> >>> >>> >>> >>> On Fri, Mar 6, 2015 at 9:16 AM, Geoff Higginbottom < >>> geoff.higginbot...@shapeblue.com> wrote: >>> >>> >>>> All, >>>> >>>> Unfortunately I've been travelling and not had chance to test fully. >>>> >>>> I did manage to test last night and found this bug is still present >>>> which I consider a Blocker. >>>> >>>> >>>> https://issues.apache.org/jira/browse/CLOUDSTACK-8248?page=com.atlassi >>>> an.jira.plugin.system.issuetabpanels:all-tabpanel >>>> >>>> I know we have formally voted yes but we need to address this as lots >>>> of folks are using VPCs >>>> >>>> Regards >>>> >>>> Geoff Higginbottom >>>> CTO / Cloud Architect >>>> >>>> D: +44 20 3603 0542<tel:+442036030542> | S: +44 20 3603 0540<tel: >>>> +442036030540> | M: +447968161581<tel:+447968161581> >>>> >>>> geoff.higginbot...@shapeblue.com<mailto:geoff.higginbottom@shapeblue.c >>>> om> >>>> | www.shapeblue.com<htp://www.shapeblue.com/> | >>>> | Twitter:@cloudstackguru< >>>> https://twitter.com/#!/cloudstackguru> >>>> >>>> ShapeBlue Ltd, 53 Chandos Place, Covent Garden, London, WC2N >>>> 4HS<x-apple-data-detectors://5> >>>> >>>> >>>> On 5 Mar 2015, at 16:14, David Nalley >>>> <da...@gnsa.us<mailto:da...@gnsa.us>> >>>> wrote: >>>> >>>> Hi all, >>>> >>>> After more than 72 hours, the vote for CloudStack 4.5.0 *passes* with >>>> 4 PMC + 2 non-PMC votes. >>>> >>>> +1 (PMC / binding) >>>> Marcus >>>> Pierre-Luc >>>> Mike >>>> Chip >>>> >>>> +1 (non binding) >>>> Rohit >>>> Nux >>>> >>>> 0 >>>> none >>>> >>>> -1 >>>> none >>>> >>>> Thanks to everyone participating. >>>> >>>> I will now prepare the release announcement to go out, likely for >>>> >>> >>> Tuesday. >>> >>>> >>>> >>>> --David >>>> >>>> >>>> On Mon, Mar 2, 2015 at 11:49 AM, David Nalley <da...@gnsa.us<mailto: >>>> da...@gnsa.us>> wrote: >>>> Hi All, >>>> >>>> I've created yet another 4.5.0 release candidate, with the following >>>> artifacts up for a vote: >>>> >>>> Git Branch and Commit SH: >>>> >>>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h= >>>> refs/heads/4.5-RC20150302T1625 >>>> Commit: c066f0455fa126a2b41cccefa25b56421a445d99 >>>> >>>> Source release (checksums and signatures are available at the same >>>> location): >>>> https://dist.apache.org/repos/dist/dev/cloudstack/4.5.0-rc4/ >>>> >>>> PGP release keys (signed using 0x6fe50f1c): >>>> https://dist.apache.org/repos/dist/release/cloudstack/KEYS >>>> >>>> Vote will be open for at least 72 hours. >>>> >>>> For sanity in tallying the vote, can PMC members please be sure to >>>> indicate "(binding)" with their vote? >>>> >>>> [ ] +1 approve >>>> [ ] +0 no opinion >>>> [ ] -1 disapprove (and reason why) >>>> Find out more about ShapeBlue and our range of CloudStack related >>>> services >>>> >>>> IaaS Cloud Design & Build< >>>> http://shapeblue.com/iaas-cloud-design-and-build//> >>>> CSForge - rapid IaaS deployment >>>> framework<http://shapeblue.com/csforge/> >>>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> >>>> CloudStack Software Engineering< >>>> http://shapeblue.com/cloudstack-software-engineering/> >>>> CloudStack Infrastructure Support< >>>> http://shapeblue.com/cloudstack-infrastructure-support/> >>>> CloudStack Bootcamp Training Courses< >>>> http://shapeblue.com/cloudstack-training/> >>>> >>>> This email and any attachments to it may be confidential and are >>>> intended solely for the use of the individual to whom it is addressed. >>>> Any views or opinions expressed are solely those of the author and do >>>> not necessarily represent those of Shape Blue Ltd or related >>>> companies. If you are not the intended recipient of this email, you >>>> must neither take any action based upon its contents, nor copy or show >>>> it to anyone. Please contact the sender if you believe you have >>>> received this email in error. Shape Blue Ltd is a company incorporated >>>> in England & Wales. ShapeBlue Services India LLP is a company >>>> incorporated in India and is operated under license from Shape Blue >>>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in >>>> Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA >>>> Pty Ltd is a company registered by The Republic of South Africa and is >>>> >>> >>> traded under license from Shape Blue Ltd. ShapeBlue is a registered >>> trademark. >>> >>>> >>>> >>>> >>> Find out more about ShapeBlue and our range of CloudStack related services >>> >>> IaaS Cloud Design & Build< >>> http://shapeblue.com/iaas-cloud-design-and-build//> >>> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> >>> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> >>> CloudStack Software Engineering< >>> http://shapeblue.com/cloudstack-software-engineering/> >>> CloudStack Infrastructure Support< >>> http://shapeblue.com/cloudstack-infrastructure-support/> >>> CloudStack Bootcamp Training Courses< >>> http://shapeblue.com/cloudstack-training/> >>> >>> This email and any attachments to it may be confidential and are intended >>> solely for the use of the individual to whom it is addressed. Any views or >>> opinions expressed are solely those of the author and do not necessarily >>> represent those of Shape Blue Ltd or related companies. If you are not the >>> intended recipient of this email, you must neither take any action based >>> upon its contents, nor copy or show it to anyone. Please contact the >>> sender >>> if you believe you have received this email in error. Shape Blue Ltd is a >>> company incorporated in England & Wales. ShapeBlue Services India LLP is a >>> company incorporated in India and is operated under license from Shape >>> Blue >>> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in >>> Brasil >>> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is >>> a company registered by The Republic of South Africa and is traded under >>> license from Shape Blue Ltd. ShapeBlue is a registered trademark. >>> >>> >> >> >> >> > > -- > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +91 8826230892 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > PS. If you see any footer below, I did not add it :) > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build// >> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Software Engineering<http://shapeblue.com/cloudstack-software- > engineering/> > CloudStack Infrastructure Support<http://shapeblue.com/ > cloudstack-infrastructure-support/> > CloudStack Bootcamp Training Courses<http://shapeblue.com/ > cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based > upon its contents, nor copy or show it to anyone. Please contact the sender > if you believe you have received this email in error. Shape Blue Ltd is a > company incorporated in England & Wales. ShapeBlue Services India LLP is a > company incorporated in India and is operated under license from Shape Blue > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is > a company registered by The Republic of South Africa and is traded under > license from Shape Blue Ltd. ShapeBlue is a registered trademark. > > > > -- > ~Rajani > Sent from Windows Phone -- Daan
