----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31295/ -----------------------------------------------------------
Review request for cloudstack and sanjeev n. Bugs: CLOUDSTACK-8276 https://issues.apache.org/jira/browse/CLOUDSTACK-8276 Repository: cloudstack-git Description ------- listNetworks API previously returned the value for vlan as "untagged" when vlan was not assigned to a network. Now the vlan attribute itself is not returned in this case. In this case, vlan attribute value by default will be None. Added the extra check in common function. Diffs ----- tools/marvin/marvin/lib/common.py c59cf10 Diff: https://reviews.apache.org/r/31295/diff/ Testing ------- Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_delete_PF_nat_rule_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disable_static_nat_3_VPC | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_1_ISOLATED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_2_SHARED | Status : SUCCESS === ok Add secondary IP to NIC of a VM ... === TestName: test_disassociate_ip_mapped_to_secondary_ip_through_PF_rule_3_VPC | Status : SUCCESS === ok Test Shared Network ALL ... ---------------------------------------------------------------------- Ran 1 test in 570.117s OK Thanks, Gaurav Aradhye