----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31081/#review72700 -----------------------------------------------------------
Ship it! 973458219734ead34253b1bf8f2b0bd29dd1b152 master - SrikanteswaraRao Talluri On Feb. 16, 2015, 12:07 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31081/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 12:07 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8258 > https://issues.apache.org/jira/browse/CLOUDSTACK-8258 > > > Repository: cloudstack-git > > > Description > ------- > > Create method in Class Iso in base library now appends random characters (6) > to the Iso name passed from test data so that each Iso created through test > case has different name. > > Hence assertios based on Iso name should be removed from test case as they > won't hold true anymore (Iso name will not match with that passed through the > test data). > > Other changes: > 1. Pep8 fixes > 2. Import fixes > 3. Removing white-spaces > 4. Removing unused variables > > > Diffs > ----- > > test/integration/smoke/test_iso.py 4bd66b5 > > Diff: https://reviews.apache.org/r/31081/diff/ > > > Testing > ------- > > Yes. One test case failed in downloading Iso due to DNS issue in the setup. > Otherwise should pass. > The test case which failed in BVT build passed in my testing. > > > Thanks, > > Gaurav Aradhye > >
