----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30660/#review72610 -----------------------------------------------------------
This is pending for review. - Gaurav Aradhye On Feb. 5, 2015, 4:26 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30660/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 4:26 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8219 > https://issues.apache.org/jira/browse/CLOUDSTACK-8219 > > > Repository: cloudstack-git > > > Description > ------- > > The function "get_free_vlan" lists all the networks in the setup and > generates a vlan in the physical vlan range which is not used by any of the > listed networks. > > However the method lists only shared networks. It should list all the > networks so that the vlan does not overlap with any of the used vlans. > > > Diffs > ----- > > tools/marvin/marvin/lib/common.py 28ec024 > > Diff: https://reviews.apache.org/r/30660/diff/ > > > Testing > ------- > > Yes. > > Test Shared Network ALL ... === TestName: test_createSharedNetwork_All | > Status : SUCCESS === > ok > Test Shared Network with scope account ... === TestName: > test_createSharedNetwork_accountSpecific | Status : SUCCESS === > ok > Test Shared Network with scope domain ... === TestName: > test_createSharedNetwork_domainSpecific | Status : SUCCESS === > ok > > > Thanks, > > Gaurav Aradhye > >
