----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30793/ -----------------------------------------------------------
Review request for cloudstack and SrikanteswaraRao Talluri. Bugs: CLOUDSTACK-8235 https://issues.apache.org/jira/browse/CLOUDSTACK-8235 Repository: cloudstack-git Description ------- Changes: 1. Corrected paramater name podId to podid while adding externally managed cluster in vmware 2. Specified detailed imports 3. Moved the vmware_cluster dict to configurableData section. 4. Pep8 fuixes. Diffs ----- test/integration/component/maint/test_bugs.py 160cd1d tools/marvin/marvin/config/test_data.py d5ed353 Diff: https://reviews.apache.org/r/30793/diff/ Testing ------- Did not test the actual adding cluster scenario. But the "Invalid parameter" error is gone. Test case needs to be run against proper data (vmware_cluster information). Checked the static errors and imports with pyflakes and python command. Thanks, Gaurav Aradhye