These two top-level "if" statements follow the same pattern: if (args.$wizard.find('input[name=compute-cpu-cores]').parent().parent().css('display') != 'none') { if (args.$wizard.find('input[name=compute-cpu-cores]').val().length > 0) {
$.extend(deployVmData, { 'details[0].cpuNumber' : args.$wizard.find('input[name=compute-cpu-cores]').val() }); } if (args.$wizard.find('input[name=compute-cpu]').val().length > 0) { $.extend(deployVmData, { 'details[0].cpuSpeed' : args.$wizard.find('input[name=compute-cpu]').val() }); } if (args.$wizard.find('input[name=compute-memory]').val().length > 0) { $.extend(deployVmData, { 'details[0].memory' : args.$wizard.find('input[name=compute-memory]').val() }); } } if (args.$wizard.find('input[name=disk-min-iops]').parent().parent().css('display') != 'none') { if (args.$wizard.find('input[name=disk-min-iops]').val().length > 0) { $.extend(deployVmData, { 'details[0].minIops' : args.$wizard.find('input[name=disk-min-iops]').val() }); } if (args.$wizard.find('input[name=disk-max-iops]').val().length > 0) { $.extend(deployVmData, { 'details[0].maxIops' : args.$wizard.find('input[name=disk-max-iops]').val() }); } } They rely on this code in index.jsp: <!-- Step 3: Service Offering --> <div class="step service-offering" wizard-step-id="service-offering"> <div class="content"> <div class="select-container"> </div> <!-- Custom size slider --> <div class="section custom-size"> <div class="field"> <label><fmt:message key="label.num.cpu.cores"/></label> <input type="text" class="required disallowSpecialCharacters" name="compute-cpu-cores" /> </div> <div class="field"> <label><fmt:message key="label.cpu.mhz"/></label> <input type="text" class="required disallowSpecialCharacters" name="compute-cpu" /> </div> <div class="field"> <label><fmt:message key="label.memory.mb"/></label> <input type="text" class="required disallowSpecialCharacters" name="compute-memory" /> </div> </div> <!-- Custom iops --> <div class="section custom-iops"> <div class="field"> <label><fmt:message key="label.disk.iops.min"/></label> <input type="text" class="disallowSpecialCharacters" name="disk-min-iops" /> </div> <div class="field"> <label><fmt:message key="label.disk.iops.max"/></label> <input type="text" class="disallowSpecialCharacters" name="disk-max-iops" /> </div> </div> </div> </div> Perhaps one of our GUI experts might know off hand why your logic after an upgrade is having trouble at that second top-level "if" statement. On Mon, Feb 2, 2015 at 8:56 PM, Mike Tutkowski <mike.tutkow...@solidfire.com > wrote: > That is an interesting question, Andrei. > > That field is optional and only used when the compute offering is > configured in such a way that we are to ask the user for Min and Max IOPS > for the root disk (just like how a compute offering can be configured to > ask the user for a number of CPUs and amount of memory). > > Off hand I don't understand why an upgrade would cause trouble here. It > works fine in all of the tests I've run where I've set the compute offering > up to both ask and not ask for these IOPS fields. > > Perhaps one of our GUI gurus can comment (I've included Brian Federle). > > On Mon, Feb 2, 2015 at 5:57 PM, Andrei Mikhailovsky <and...@arhont.com> > wrote: > >> Mike, >> >> I am not really sure how to do that. >> >> Here is what I've done so far, perhaps you could help me with some >> instructions. >> >> I've opened debugging console in Firefox and checked the Console tab. >> After i've followed the add instance wizard while watching the messages in >> the Console. No errors until I've clicked the launch button. After that >> I've got the following message: >> >> TypeError: args.$wizard.find(...).val(...) is undefined >> instanceWizard.js:649 >> >> Looking at the line 649 in the instanceWizard.js: >> >> if (args.$wizard.find('input[name=disk-min-iops]').val().length > 0) { >> >> So, it seem to be looking for the disk-min-iops value which is not >> defined during the wizard creation. I do not recall ever being required to >> specify these values in the past. Thus, not sure why it needs these values >> all of a sudden after performing an upgrade from acs 4.3.2? >> >> Any idea anyone? >> >> Cheers >> >> ----- Original Message ----- >> >> > From: "Mike Tutkowski" <mike.tutkow...@solidfire.com> >> > To: dev@cloudstack.apache.org >> > Sent: Monday, 2 February, 2015 9:25:31 PM >> > Subject: Re: Major breakage in GUI after upgrade from 4.3.2 to 4.4.2 >> >> > Hey Andrei, >> >> > Are you familiar with debugging in your web browser? >> >> > One thing you could try is to set a breakpoint in instanceWizard.js >> > where >> > deployVirtualMachine is invoked and see what happens. >> >> > Talk to you later, >> > Mike >> >> > On Mon, Feb 2, 2015 at 2:16 PM, Andrei Mikhailovsky >> > <and...@arhont.com> >> > wrote: >> >> > > Mike, you are absolutely right, thanks! The delete function has >> > > been >> > > hidden under the Zones tab (in my version of GUI it is shown as >> > > "label.zones"). So, this one is sorted out. >> > > >> > > Now, I wonder how to fix the major issue #1 - unable to create new >> > > vm >> > > instances? Anyone any thoughts? >> > > >> > > Thanks >> > > >> > > Andrei >> > > >> > > ----- Original Message ----- >> > > >> > > > From: "Mike Tutkowski" <mike.tutkow...@solidfire.com> >> > > > To: dev@cloudstack.apache.org >> > > > Sent: Monday, 2 February, 2015 7:38:39 PM >> > > > Subject: Re: Major breakage in GUI after upgrade from 4.3.2 to >> > > > 4.4.2 >> > > >> > > > I wonder for your Major issue #2 if you have drilled down into >> > > > the >> > > > applicable zone from which you want to delete the template? >> > > >> > > > I had trouble finding this at one point, as well. >> > > >> > > > I don't have easy access to a 4.4 GUI at the time being, but in >> > > > 4.6 >> > > > you >> > > > need to go to Templates, click on the template in the table, >> > > > select >> > > > the >> > > > Zone tab, click on the applicable zone in the table, then you see >> > > > a >> > > > delete >> > > > button. >> > > >> > > > On Mon, Feb 2, 2015 at 12:23 PM, Andrei Mikhailovsky >> > > > <and...@arhont.com> >> > > > wrote: >> > > >> > > > > Hi guys, >> > > > > >> > > > > Sorry for duplicating the message from the user list. I've not >> > > > > got >> > > > > anywhere there. >> > > > > >> > > > > I've recently upgraded my ASC from version 4.3.2 to version >> > > > > 4.4.2. >> > > > > The >> > > > > upgrade process went well without any setbacks or issues. I've >> > > > > not >> > > > > seen any >> > > > > errors in the log files. All looks good apart from the GUI >> > > > > issues. >> > > > > I've >> > > > > tried to clear browser caches and pressed force refresh as >> > > > > well. >> > > > > This >> > > > > happens in Firefox as well as Chrome. >> > > > > >> > > > > The following major issue that i've identified so far: >> > > > > >> > > > > 1. I can no longer create new instances. Regardless of if I am >> > > > > doing it >> > > > > from the ISO or existing Templates. After following the Add >> > > > > Instance wizard >> > > > > and clicking on the Launch button nothing happens. The wizard >> > > > > window >> > > > > becomes shaded and the spinning circle appears. I've left it >> > > > > for >> > > > > hours >> > > > > without any change. When the Launch button is pressed, the >> > > > > management >> > > > > server does not receive an API call to create an instance. >> > > > > There >> > > > > are >> > > > > actually nothing in the logs after the button is pressed. >> > > > > However, >> > > > > I can >> > > > > successfully create new instances by using the CloudMonkey >> > > > > clie. >> > > > > 2. There is no Delete button for Templates and ISOs. The Edit >> > > > > and >> > > > > Download >> > > > > buttons are there, but not the Delete button. >> > > > > >> > > > > The following minor issues that i've seen so far: >> > > > > >> > > > > 1. The elements in the Dashboard screen are not fitting their >> > > > > corresponding boxes. They stick out and not aligning properly >> > > > > 2. Some Tabs are not labeled properly and instead show >> > > > > something >> > > > > like: >> > > > > label.zones or label.add.isolated.network and a few more that >> > > > > i've >> > > > > noticed, >> > > > > but can't recall exactly what they were. But it seems that >> > > > > these >> > > > > labels are >> > > > > all over the place (probably about 20% of all Tabs and buttons >> > > > > in >> > > > > the GUI) >> > > > > >> > > > > >> > > > > Has anyone else seen these types of issues with the 4.4.x >> > > > > branch? >> > > > > Any >> > > > > thoughts on what is causing the issues and how to resolve them? >> > > > > >> > > > > Thanks >> > > > > >> > > > > Andrei >> > > > > >> > > >> > > > -- >> > > > *Mike Tutkowski* >> > > > *Senior CloudStack Developer, SolidFire Inc.* >> > > > e: mike.tutkow...@solidfire.com >> > > > o: 303.746.7302 >> > > > Advancing the way the world uses the cloud >> > > > <http://solidfire.com/solution/overview/?video=play>*™* >> > > >> >> > -- >> > *Mike Tutkowski* >> > *Senior CloudStack Developer, SolidFire Inc.* >> > e: mike.tutkow...@solidfire.com >> > o: 303.746.7302 >> > Advancing the way the world uses the cloud >> > <http://solidfire.com/solution/overview/?video=play>*™* >> > > > > -- > *Mike Tutkowski* > *Senior CloudStack Developer, SolidFire Inc.* > e: mike.tutkow...@solidfire.com > o: 303.746.7302 > Advancing the way the world uses the cloud > <http://solidfire.com/solution/overview/?video=play>*™* > -- *Mike Tutkowski* *Senior CloudStack Developer, SolidFire Inc.* e: mike.tutkow...@solidfire.com o: 303.746.7302 Advancing the way the world uses the cloud <http://solidfire.com/solution/overview/?video=play>*™*