After poking around the code a bit, this is purely an API issue (was worried there was more). When I made the change I explicitly *didn't* change the actual method names so for example there is still a getXenLabel() call on the physical network traffic API calls. That's probably why we didn't see this sooner, and my fault for not thinking this one through as well as I should've.
The simplest and fastest answer is to keep Rohit's revert and tackle it when we get pure Xen in. The second option would be to create an explicit getXenServerLabel() call which is wrapped by getXenLabel() to do the name translation. Then we mark the getXenLabel() call as deprecated in the docs, with backwards compat preserved and future work should use getXenServerLabel(). The second option is obviously the technically"correct" way to version the API, but will take a bit longer to work through. I'm OK with going back to "xennetworklabel" for 4.5 and putting in a ticket in against master to do the more complete fix. I also looked at Marvin, and found something which to my eye looks incorrect, and might also explain why we didn't see this earlier. tools/marvin/marvin/deployDataCenter.py line 613/614 has a traffictype.xen, but I *think* that should be traffictype.xenserver. If I'm reading things correctly, that code looks like it's been skipped for XenServer for a while. Is there any easy way to validate? -tim On Mon, Feb 2, 2015 at 2:52 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > Hi Tim, > > You may be right on this one, we just want to make sure. Feel free to > revert the fix is there is a better way around. I personally would like > to avoid string changes because as Geoff mentions it changes the > interface for 3rd party consumers such as CLI scripts, custom UI and > possibly others. > > On Monday 02 February 2015 04:53 PM, Tim Mackey wrote: > >> Iirc, that was the only one. >> >> I don't agree with the reversion, but let me look at supporting both >> once I get to my desk. Do we have any api commitment specs out there? >> If so, I'd like to mark the "Xen" one deprecated >> >> On Feb 2, 2015 11:14 AM, "Geoff Higginbottom" >> <geoff.higginbot...@shapeblue.com >> <mailto:geoff.higginbot...@shapeblue.com>> wrote: >> >> Hi Tim,____ >> >> __ __ >> >> The issue affects new deployments using existing tooling which >> references the original api parameter of xentrafficlabel.____ >> >> __ __ >> >> It will also affect any tooling which may update the labels, >> although this is a rare occurance.____ >> >> __ __ >> >> The main issue is backwards compatibility, but also a concern that >> there may be other areas where the api parameters have changed from >> xen to xenserver.____ >> >> __ __ >> >> Anyone who has developed a custom UI may run into issues.____ >> >> __ __ >> >> Is there a list of all the API changes that have been made?____ >> >> __ __ >> >> Regards____ >> >> __ __ >> >> Geoff Higginbottom____ >> >> __ __ >> >> D: +44 20 3603 0542 <tel:+442036030542>| S: +44 20 3603 0540 >> <tel:+442036030540>| M: +447968161581 <tel:+447968161581>____ >> >> __ __ >> >> geoff.higginbot...@shapeblue.com >> <mailto:geoff.higginbot...@shapeblue.com>____ >> >> __ __ >> >> *From:*Tim Mackey [mailto:tmac...@gmail.com <mailto:tmac...@gmail.com >> >] >> *Sent:* 02 February 2015 11:05 >> *To:* Rohit Yadav >> *Cc:* Geoff Higginbottom; dev@cloudstack.apache.org >> <mailto:dev@cloudstack.apache.org> >> *Subject:* Re: [DISCUSS] Important: XenServer labels reverted for >> backward compatibility____ >> >> __ __ >> >> Rohit, how does the issue manifest itself? I ask because I thought >> I'd taken care of every scenario during upgrade.____ >> >> On Feb 2, 2015 10:52 AM, "Rohit Yadav" <rohit.ya...@shapeblue.com >> <mailto:rohit.ya...@shapeblue.com>> wrote:____ >> >> Hi Tim, >> >> Geoff found a issue today that breaks backward compatibility for >> XenServer users. >> >> Until 4.4, XenServer traffic label was xennetworklabel but in >> 4.5/master >> it is xenservernetworklabel. To keep backward compatibility I'm >> reverting such changes introduced in >> a8212d9ef458dd7ac64b021e6fa33fcf64b3cce0 (xenserver plugin >> refactoring). >> When in future we'll have a separate xen project plugin (based on >> libvirt or what have you) we should add a new label like >> xenprojectnetworklabel but let's keep the old one for backward >> compatibility's sake. >> >> It could be valid change, if so please advise any other way to >> maintain >> backward compatibility? Please comment if this is okay? >> >> The issue has been fixed on 4.5/master now: >> https://issues.apache.org/jira/browse/CLOUDSTACK-8190 >> >> Regards, >> Rohit Yadav >> Software Architect, ShapeBlue >> M. +91 8826230892 <tel:%2B91%208826230892> | >> rohit.ya...@shapeblue.com <mailto:rohit.ya...@shapeblue.com> >> Blog: bhaisaab.org <http://bhaisaab.org> | Twitter: @_bhaisaab >> PS. If you see any footer below, I did not add it :) >> Find out more about ShapeBlue and our range of CloudStack >> related services >> >> IaaS Cloud Design & >> Build<http://shapeblue.com/iaas-cloud-design-and-build// >> <http://shapeblue.com/iaas-cloud-design-and-build/>> >> CSForge – rapid IaaS deployment >> framework<http://shapeblue.com/csforge/> >> CloudStack Consulting<http://shapeblue. >> com/cloudstack-consultancy/> >> CloudStack Software >> Engineering<http://shapeblue.com/cloudstack-software-engineering/ >> > >> CloudStack Infrastructure >> Support<http://shapeblue.com/cloudstack-infrastructure-support/> >> CloudStack Bootcamp Training >> Courses<http://shapeblue.com/cloudstack-training/> >> >> This email and any attachments to it may be confidential and are >> intended solely for the use of the individual to whom it is >> addressed. Any views or opinions expressed are solely those of >> the author and do not necessarily represent those of Shape Blue >> Ltd or related companies. If you are not the intended recipient >> of this email, you must neither take any action based upon its >> contents, nor copy or show it to anyone. Please contact the >> sender if you believe you have received this email in error. >> Shape Blue Ltd is a company incorporated in England & Wales. >> ShapeBlue Services India LLP is a company incorporated in India >> and is operated under license from Shape Blue Ltd. Shape Blue >> Brasil Consultoria Ltda is a company incorporated in Brasil and >> is operated under license from Shape Blue Ltd. ShapeBlue SA Pty >> Ltd is a company registered by The Republic of South Africa and >> is traded under license from Shape Blue Ltd. ShapeBlue is a >> registered trademark.____ >> >> >> Find out more about ShapeBlue and our range of CloudStack related >> services >> >> IaaS Cloud Design & Build >> <http://shapeblue.com/iaas-cloud-design-and-build//> >> CSForge – rapid IaaS deployment framework >> <http://shapeblue.com/csforge/> >> CloudStack Consulting <http://shapeblue.com/cloudstack-consultancy/> >> CloudStack Software Engineering >> <http://shapeblue.com/cloudstack-software-engineering/> >> CloudStack Infrastructure Support >> <http://shapeblue.com/cloudstack-infrastructure-support/> >> CloudStack Bootcamp Training Courses >> <http://shapeblue.com/cloudstack-training/> >> >> This email and any attachments to it may be confidential and are >> intended solely for the use of the individual to whom it is >> addressed. Any views or opinions expressed are solely those of the >> author and do not necessarily represent those of Shape Blue Ltd or >> related companies. If you are not the intended recipient of this >> email, you must neither take any action based upon its contents, nor >> copy or show it to anyone. Please contact the sender if you believe >> you have received this email in error. Shape Blue Ltd is a company >> incorporated in England & Wales. ShapeBlue Services India LLP is a >> company incorporated in India and is operated under license from >> Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company >> incorporated in Brasil and is operated under license from Shape Blue >> Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of >> South Africa and is traded under license from Shape Blue Ltd. >> ShapeBlue is a registered trademark. >> >> > -- > > Regards, > Rohit Yadav > Software Architect, ShapeBlue > M. +91 8826230892 | rohit.ya...@shapeblue.com > Blog: bhaisaab.org | Twitter: @_bhaisaab > PS. If you see any footer below, I did not add it :) > Find out more about ShapeBlue and our range of CloudStack related services > > IaaS Cloud Design & Build<http://shapeblue.com/ > iaas-cloud-design-and-build//> > CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> > CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> > CloudStack Software Engineering<http://shapeblue.com/cloudstack-software- > engineering/> > CloudStack Infrastructure Support<http://shapeblue.com/ > cloudstack-infrastructure-support/> > CloudStack Bootcamp Training Courses<http://shapeblue.com/ > cloudstack-training/> > > This email and any attachments to it may be confidential and are intended > solely for the use of the individual to whom it is addressed. Any views or > opinions expressed are solely those of the author and do not necessarily > represent those of Shape Blue Ltd or related companies. If you are not the > intended recipient of this email, you must neither take any action based > upon its contents, nor copy or show it to anyone. Please contact the sender > if you believe you have received this email in error. Shape Blue Ltd is a > company incorporated in England & Wales. ShapeBlue Services India LLP is a > company incorporated in India and is operated under license from Shape Blue > Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil > and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is > a company registered by The Republic of South Africa and is traded under > license from Shape Blue Ltd. ShapeBlue is a registered trademark. >
