----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29094/#review65307 -----------------------------------------------------------
Ship it! It would be nice to fix these irrespective of the code modified by you: pep8 test/integration/component/maint/test_multiple_ip_ranges.py test/integration/component/maint/test_multiple_ip_ranges.py:83:80: E501 line too long (102 > 79 characters) test/integration/component/maint/test_multiple_ip_ranges.py:142:50: E231 missing whitespace after ',' test/integration/component/maint/test_multiple_ip_ranges.py:160:17: E126 continuation line over-indented for hanging indent test/integration/component/maint/test_multiple_ip_ranges.py:168:80: E501 line too long (85 > 79 characters) - SrikanteswaraRao Talluri On Dec. 16, 2014, 11:53 a.m., Ashutosh Kelkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29094/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 11:53 a.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-8074 > https://issues.apache.org/jira/browse/CLOUDSTACK-8074 > > > Repository: cloudstack-git > > > Description > ------- > > There were many issues in this test suite, almost rewrote it (69%). > > > Diffs > ----- > > test/integration/component/maint/test_multiple_ip_ranges.py 982dd7c > > Diff: https://reviews.apache.org/r/29094/diff/ > > > Testing > ------- > > Deploy guest vm after adding guest IP range in new CIDR ... === TestName: > test_01_deploy_vm_in_new_cidr | Status : SUCCESS === > ok > Deploy guest vm in new CIDR and verify dns service on alias ip ... === > TestName: test_02_dns_service_on_alias_ip | Status : SUCCESS === > ok > Deploy guest vm in new CIDR and verify passwd service on alias ip ... === > TestName: test_03_passwd_service_on_alias_IP | Status : SUCCESS === > ok > Deploy guest vm in new CIDR and verify userdata service on alias ip ... === > TestName: test_04_userdata_service_on_alias_IP | Status : SUCCESS === > ok > Destroy lastvm in the CIDR and verifly alias removal ... === TestName: > test_05_del_cidr_verify_alias_removal | Status : SUCCESS === > ok > Reboot VR and verify ip alias ... === TestName: > test_06_reboot_VR_verify_ip_alias | Status : SUCCESS === > ok > Reboot VR and verify ip alias ... === TestName: > test_07_stop_start_VR_verify_ip_alias | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 7 tests in 1151.865s > > OK > > > Thanks, > > Ashutosh Kelkar > >
