----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20078/ -----------------------------------------------------------
(Updated déc. 8, 2014, 9:31 matin) Review request for cloudstack, Anshul Gangwar, Brian Federle, Chiradeep Vittal, Jessica Wang, and Sanjay Tripathi. Changes ------- update to apply cleanly on master Repository: cloudstack-git Description (updated) ------- (Port of https://reviews.apache.org/r/16688/ to master branch) Firstly, I add a match condition 'altgr' for "Conditional mapping entry" in ajaxviwer.js. altgr : <altgr state match condition>, -- match on altgr state It works like the shift match condition. shift : <shift state match condition>, -- match on shift state Browser can't detect difference between AltGr and Ctrl+Alt pressed at the same time. So when the modifier is 896, (Alt(512) + Ctrl(384)) I assume it is the AltGr key and 'altgr' condition will be true. In the ajaxkey.js file you got for example: {type: KEY_DOWN, code: 0x32, modifiers: 0, altgr: true} to send the spécified key to vnc if user pressed the AltGr (or Ctrl+Alt) key Secondly, I wrote the French AZERTY translation table in ajaxkeys.js with the support of AltGr character (like #{}[]|,etc.) For example the '#': {keycode: 51, entry: [ //User type the "3# key and each condition match 'altgr' {type: KEY_DOWN, code: 0xffea, modifiers: 0, altgr: true}, //press the VNC AltGR key {type: KEY_DOWN, code: 0x33, modifiers: 0, altgr: true}, //press the 3 key {type: KEY_UP, code: 0x33, modifiers: 0, altgr: true}, //release it {type: KEY_UP, code: 0xffea, modifiers: 0, altgr: true} //release the AltGr key ]}, Thanks for watching my work Axel Delahaye Diffs (updated) ----- services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientBase.java eb38007 systemvm/css/ajaxviewer.css fd2fb3c systemvm/js/ajaxkeys.js 8f78cc8 systemvm/js/ajaxviewer.js ff899b1 Diff: https://reviews.apache.org/r/20078/diff/ Testing ------- Tested with Hardware : French AZERTY keyboard Software : Configured in windows as FR keyboard Console-proxy : Customized Standard (US) keyboard Guest : CentOS 6.5 , Debian 7 and FreeBSD 8 Guest keymap : fr, fr-pc Thanks, Axel Delahaye
