> On Nov. 30, 2014, 10:16 p.m., Pierre-Luc Dion wrote: > > Cannot be merge into 4.5 branch their is conflict in > > ``test/integration/component/test_security_groups.py`` > > Gaurav Aradhye wrote: > Thanks Pierre-Luc, I will check, and put rebased patch.
Can you please try now? It wasn't applying cleanly because one of the commits was missing in branch 4.5. It applies cleanly now. - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28523/#review63320 ----------------------------------------------------------- On Nov. 28, 2014, 2:25 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28523/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2014, 2:25 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7991 > https://issues.apache.org/jira/browse/CLOUDSTACK-7991 > > > Repository: cloudstack-git > > > Description > ------- > > Moving the config data in the test case to test_data.py > Keeping host credentails in configurableData section. > Fixing pep8 issues. > > > Diffs > ----- > > test/integration/component/test_security_groups.py eb242c7 > tools/marvin/marvin/config/test_data.py f0802a5 > > Diff: https://reviews.apache.org/r/28523/diff/ > > > Testing > ------- > > Yes. Two test cases failing for different reason. > > Log: > Test authorize ingress rule ... === TestName: test_01_authorizeIngressRule | > Status : SUCCESS === > ok > Test deploy VM in default security group ... === TestName: > test_01_deployVM_InDefaultSecurityGroup | Status : SUCCESS === > ok > Test list security groups for admin account ... === TestName: > test_02_listSecurityGroups | Status : SUCCESS === > ok > Test access in default security group ... === TestName: > test_03_accessInDefaultSecurityGroup | Status : SUCCESS === > ok > Test delete security group with running VM ... === TestName: > test_01_delete_security_grp_running_vm | Status : SUCCESS === > ok > Test delete security group without running VM ... === TestName: > test_02_delete_security_grp_withoout_running_vm | Status : SUCCESS === > ok > Test router services for user account ... === TestName: > test_01_dhcpOnlyRouter | Status : SUCCESS === > ok > Test delete security group with running VM ... === TestName: > test_01_authorizeIngressRule_AfterDeployVM | Status : SUCCESS === > ok > Test Revoke ingress rule after deploy VM ... === TestName: > test_02_revokeIngressRule_AfterDeployVM | Status : FAILED === > FAIL > Test Start/Stop VM and Verify ingress rule ... === TestName: > test_03_stopStartVM_verifyIngressAccess | Status : SUCCESS === > ok > Test revoke ingress rule ... === TestName: test_01_revokeIngressRule | Status > : FAILED === > FAIL > Test Deploy VM with User data ... === TestName: test_01_deployVMWithUserData > | Status : SUCCESS === > ok > > > Thanks, > > Gaurav Aradhye > >
