----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28490/#review63165 -----------------------------------------------------------
Ship it! Ship It! - sangeetha hariharan On Nov. 27, 2014, 12:14 a.m., Chandan Purushothama wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28490/ > ----------------------------------------------------------- > > (Updated Nov. 27, 2014, 12:14 a.m.) > > > Review request for cloudstack and sangeetha hariharan. > > > Bugs: CLOUDSTACK-7979 > https://issues.apache.org/jira/browse/CLOUDSTACK-7979 > > > Repository: cloudstack-git > > > Description > ------- > > Currently, test cases in the test suite do not pass the Zone Network Type to > the Virtual Machine class create method. This doesn't cause any problem with > majority of the configurations except EIP-ELB Configuration. Hence Zone > Network Type Information should be passed consciously to the create method to > cover EIP-ELB Configuration. > > > Diffs > ----- > > test/integration/component/test_security_groups.py 89317f4 > > Diff: https://reviews.apache.org/r/28490/diff/ > > > Testing > ------- > > Executed One Test to prove the fix. This test belongs to a different test > suite. But the fix is the same: > > Test authorize ingress rule ... === TestName: test_authorizeIngressRule | > Status : SUCCESS === > ok > > > Ran 1 test in 126.613s > > OK > > > Thanks, > > Chandan Purushothama > >
