----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28043/#review61632 -----------------------------------------------------------
The changes look good to me except the repeated code in networks.js. Is it possible to move it to a function and reuse? Also, Can you update 'Testing Done' section and confirm that the changes are tested. Thanks, Rajani - Rajani Karuturi On Nov. 14, 2014, 6:15 p.m., Daniel Vega Simoes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28043/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 6:15 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > JIRA: CLOUDSTACK 7915 > > Removed hard-coded values for Load Balancer algorithms in UI. > > Instead, now UI sets values loaded dynamically through load balancer provider > capabilities. > > Also updated internationalization messages. > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties 86eb5c2 > client/WEB-INF/classes/resources/messages_ar.properties 4f65118 > client/WEB-INF/classes/resources/messages_es.properties f2d754e > client/WEB-INF/classes/resources/messages_fr_FR.properties 004187f > client/WEB-INF/classes/resources/messages_it_IT.properties e2f3f0b > client/WEB-INF/classes/resources/messages_ja_JP.properties 7bc90b5 > client/WEB-INF/classes/resources/messages_ko_KR.properties ce79d2e > client/WEB-INF/classes/resources/messages_nb_NO.properties c169112 > client/WEB-INF/classes/resources/messages_nl_NL.properties 89ef828 > client/WEB-INF/classes/resources/messages_pl.properties 06d5ec2 > client/WEB-INF/classes/resources/messages_pt_BR.properties 8ee08ba > client/WEB-INF/classes/resources/messages_ru_RU.properties ff68668 > client/WEB-INF/classes/resources/messages_zh_CN.properties ebba5e0 > ui/dictionary.jsp 671f48f > ui/scripts/network.js c27b999 > ui/scripts/vpc.js af19d87 > > Diff: https://reviews.apache.org/r/28043/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Vega Simoes > >
