----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28049/#review61631 -----------------------------------------------------------
Can you please update the testing section? probably a new test case if possible? It might break some of the existing unit or integration tests. Did you run them? information about running/writing new tests can be found here https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python - Rajani Karuturi On Nov. 14, 2014, 7:42 p.m., Daniel Vega Simoes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28049/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2014, 7:42 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > JIRA: https://issues.apache.org/jira/browse/CLOUDSTACK-7917 > Validate Load Balancer rule with provider before commiting to DB and applying > new rule. > > > Diffs > ----- > > server/src/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java a28d108 > > Diff: https://reviews.apache.org/r/28049/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Vega Simoes > >
