----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26866/#review57165 -----------------------------------------------------------
Ship it! Ship It! - anthony xu On Oct. 17, 2014, 7:46 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26866/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 7:46 a.m.) > > > Review request for cloudstack, anthony xu and Devdeep Singh. > > > Bugs: CLOUDSTACK-7747 > https://issues.apache.org/jira/browse/CLOUDSTACK-7747 > > > Repository: cloudstack-git > > > Description > ------- > > Currently we extend support for all the possible combinations .In cases were > the Vm start changes from “Stopped” to “Running”, CS does not account for > this VM’s capacity and VM start does not use our allocators. > > Following will be the only configuration we would have to support: > > 1.Revert a "Running" VM to a "Disk and Memory" Snapshot ( with and without > "quiesce" option). > 2.Revert a "Stopped" VM to a "Disk " Snapshot ( with and without "quiesce" > option). > > > Diffs > ----- > > server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 > > Diff: https://reviews.apache.org/r/26866/diff/ > > > Testing > ------- > > tested that VM snapshot revert not allowed for running VM to disk type VM > snapshot and stopped VM to disk and memory type snapshot. > > > Thanks, > > Anshul Gangwar > >
