----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26482/#review56739 -----------------------------------------------------------
Ship it! Ship It! - anthony xu On Oct. 9, 2014, 9:09 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26482/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 9:09 a.m.) > > > Review request for cloudstack, anthony xu and Devdeep Singh. > > > Bugs: CLOUDSTACK-7688 > https://issues.apache.org/jira/browse/CLOUDSTACK-7688 > > > Repository: cloudstack-git > > > Description > ------- > > VM snapshots stops working when following operations are performed on VM with > VM snapshots > > 1. Volumes of VM are migrated to other storage > 2. Add and remove NIC to/from VM > 3. Attach and Detach volume to VM > 4. Scale up/down of VM(change service offering) > 5. Volume snapshot which is not major use case in this scenario > 6. Resize volume > 7. Live migration of VM which involves storage migration > 8. Do not allow VM snapshot in case VM snapshot already exists > > This patche adds the above restrictions > > > Diffs > ----- > > server/src/com/cloud/storage/VolumeApiServiceImpl.java e089b77 > server/src/com/cloud/vm/UserVmManagerImpl.java 2636096 > server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java f85f6c8 > > Diff: https://reviews.apache.org/r/26482/diff/ > > > Testing > ------- > > verified that all the above operations are not allowed > > > Thanks, > > Anshul Gangwar > >
