----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26134/#review55648 -----------------------------------------------------------
Ship it! cd672709c35e92a4a5a9767e2d2e60aa91fd8e73 master - SrikanteswaraRao Talluri On Sept. 29, 2014, 10:17 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26134/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 10:17 a.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7644 > https://issues.apache.org/jira/browse/CLOUDSTACK-7644 > > > Repository: cloudstack-git > > > Description > ------- > > Reason of failure: > The test cases which were trying to connecte via SSH after configuring LB > rule were failing because the LB rule has public port 2222, but SSH was > connecting to default port 22. > > Changes: > 1. Correct port number is passed now to the SSH method. > 2. Fixed all pep8 issues > > > Diffs > ----- > > test/integration/component/test_persistent_networks.py 02f6229 > > Diff: https://reviews.apache.org/r/26134/diff/ > > > Testing > ------- > > Yes. This change fixed following 3 test cases. > > Logs: > test_vpc_delete_account (test_persistent_networks.TestVPCNetworkOperations) > ... === TestName: test_vpc_delete_account | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 1 test in 519.039s > > OK > ~ > > > test_cleanup_persistent_network_1_true > (test_persistent_networks.TestRestartPersistentNetwork) ... === TestName: > test_cleanup_persistent_network_1_true | Status : > SUCCESS === > ok > test_cleanup_persistent_network_2_false > (test_persistent_networks.TestRestartPersistentNetwork) ... === TestName: > test_cleanup_persistent_network_2_false | Status : > SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 2 tests in 564.115s > > OK > > > Thanks, > > Gaurav Aradhye > >