----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26364/#review55644 -----------------------------------------------------------
It is better to add code to find out exact gateway IP rather than finding from a list of IPs. Right now, this happens only in the case of EIP/ELB zones. - SrikanteswaraRao Talluri On Oct. 6, 2014, 3 p.m., Alex Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26364/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2014, 3 p.m.) > > > Review request for cloudstack and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7673 > https://issues.apache.org/jira/browse/CLOUDSTACK-7673 > > > Repository: cloudstack-git > > > Description > ------- > > In some situations (e.g. EIP) listVlanRanges can return multiple entries, > however the checks in test_ssvm.py were only ever looking at the first result, > therefore these tests could incorrectly fail. > > Modify the check to look at all returned gateways for a match > > > Diffs > ----- > > test/integration/smoke/test_ssvm.py 5713569 > > Diff: https://reviews.apache.org/r/26364/diff/ > > > Testing > ------- > > Verified the tests pass in a normal scenario > > > Thanks, > > Alex Brett > >
