----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26023/#review54663 -----------------------------------------------------------
Ship it! e5efa702bbd57a1855d68ea3df5c0aee3db85dcc master - SrikanteswaraRao Talluri On Sept. 25, 2014, 7:04 a.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26023/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 7:04 a.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7603 > https://issues.apache.org/jira/browse/CLOUDSTACK-7603 > > > Repository: cloudstack-git > > > Description > ------- > > Few test cases in test suite test_escalations_network.py were using VPC > offering already present in the setup to create the VPC. They should create > their own VPC offering and remove it after the run has completed. > > Changes: > 1. Create VPC offering in setUpClass and used it in test cases. > 2. Removed import * > 3. Fixed pep8 issues > > > Diffs > ----- > > test/integration/component/test_escalations_networks.py 5fad43a > > Diff: https://reviews.apache.org/r/26023/diff/ > > > Testing > ------- > > Yes. > > One test case failed due to site to site VPN issue, it is already being > tracked under different Bug. > > Log: > @Desc: Test List Networks pagination ... === TestName: > test_01_list_networks_pagination | Status : SUCCESS === > ok > @Desc: Test create network if supported services doesn't have sourcenat ... > === TestName: test_02_create_network_without_sourcenat | Status : SUCCESS === > ok > @Desc: Test create vpc with network domain as parameter ... === TestName: > test_03_list_vpc_pagination | Status : SUCCESS === > ok > @Desc: Test create vpc with network domain as parameter ... === TestName: > test_04_create_vpc_with_networkdomain | Status : SUCCESS === > ok > @Desc: Test list network offerings for vpc true and false parameters ... === > TestName: test_05_list_network_offerings_with_and_without_vpc | Status : > SUCCESS === > ok > @Desc: Test create network in vpc and verify VPC name ... === TestName: > test_06_create_network_in_vpc | Status : SUCCESS === > ok > @Desc: Test delete network ... === TestName: test_07_create_delete_network | > Status : SUCCESS === > ok > @Desc: Test update network ... === TestName: test_08_update_network | Status > : SUCCESS === > ok > @Desc: Test update network ... === TestName: > test_09_list_virtual_machines_single_network | Status : SUCCESS === > ok > @Desc: Test list networks in vpc and verify VPC name ... === TestName: > test_10_list_networks_in_vpc | Status : SUCCESS === > ok > @Desc: Test create vpc with network domain as parameter ... === TestName: > test_11_update_vpc | Status : SUCCESS === > ok > @Desc: Test create network in vpc and verify VPC name ... === TestName: > test_12_list_create_delete_networkACL | Status : SUCCESS === > ok > @summary: Test List VPC with Id ... === TestName: test_13_list_vpc_byid | > Status : SUCCESS === > ok > @summary: Test List Public IPAddress with associatednetworkid ... === > TestName: test_14_list_public_ipadress_by_associated_networkid | Status : > SUCCESS === > ok > @summary: Test List PrivateGateway by vpcid ... === TestName: > test_15_list_privategateway_byvpcid | Status : SUCCESS === > ok > @summary: Test Create List Delete Egress Firewall Rule by Network ID ... === > TestName: test_16_create_list_delete_egressfirewallrule_bynetworkid | Status > : SUCCESS === > ok > @summary: Test to restart VPC ... === TestName: test_17_restart_vpc | Status > : SUCCESS === > ok > @Desc: Test to Create and list Vpn Gateway by VPCid ... === TestName: > test_18_create_list_vpn_gateway | Status : SUCCESS === > ok > @Desc: Test to List Create Reset and Delete VPN Customer ... === TestName: > test_19_create_list_reset_delete_vpnconnections | Status : EXCEPTION === > ERROR > @summary: Test List Capabilities ... === TestName: test_20_list_capabilities > | Status : SUCCESS === > ok > @summary: Test to list Networkacllists by private gateway aclid ... === > TestName: test_21_listNetworkacls_by_privategateway_aclid | Status : SUCCESS > === > ok > > > Thanks, > > Gaurav Aradhye > >