> On Sept. 18, 2014, 10:54 a.m., SrikanteswaraRao Talluri wrote: > > Please fix the below pep8 issues and re-submit the patch. > > > > test/integration/component/test_escalations_volumes.py:128:80: E501 line > > too long (80 > 79 characters) > > test/integration/component/test_escalations_volumes.py:131:80: E501 line > > too long (113 > 79 characters) > > test/integration/component/test_escalations_volumes.py:149:80: E501 line > > too long (81 > 79 characters) > > test/integration/component/test_escalations_volumes.py:160:80: E501 line > > too long (84 > 79 characters) > > test/integration/component/test_escalations_volumes.py:164:80: E501 line > > too long (80 > 79 characters) > > test/integration/component/test_escalations_volumes.py:203:80: E501 line > > too long (91 > 79 characters) > > test/integration/component/test_escalations_volumes.py:232:80: E501 line > > too long (88 > 79 characters) > > test/integration/component/test_escalations_volumes.py:249:80: E501 line > > too long (87 > 79 characters) > > test/integration/component/test_escalations_volumes.py:325:80: E501 line > > too long (87 > 79 characters) > > test/integration/component/test_escalations_volumes.py:526:80: E501 line > > too long (103 > 79 characters) > > test/integration/component/test_escalations_volumes.py:685:80: E501 line > > too long (112 > 79 characters) > > test/integration/component/test_escalations_volumes.py:902:80: E501 line > > too long (81 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1033:80: E501 line > > too long (80 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1163:80: E501 line > > too long (81 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1293:80: E501 line > > too long (82 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1304:80: E501 line > > too long (80 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1441:80: E501 line > > too long (80 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1445:80: E501 line > > too long (92 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1553:80: E501 line > > too long (90 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1568:80: E501 line > > too long (90 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1732:80: E501 line > > too long (83 > 79 characters) > > test/integration/component/test_escalations_volumes.py:1753:80: E501 line > > too long (86 > 79 characters)
Fixed - Gaurav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25734/#review53799 ----------------------------------------------------------- On Sept. 17, 2014, 6:51 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25734/ > ----------------------------------------------------------- > > (Updated Sept. 17, 2014, 6:51 p.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7565 > https://issues.apache.org/jira/browse/CLOUDSTACK-7565 > > > Repository: cloudstack-git > > > Description > ------- > > Attach volume test cases failed with following exception from QEMU: > internal error unable to execute QEMU command '__com.redhat_drive_add': > Duplicate ID 'drive-virtio-disk1' for drive > > It has been observed that this issue occurs when disks are repeatedly > attached and detached from VM and this is an intermittent issue. > > However we can avoid this issue by creating new account and a VM in it and > attaching volume to this VM. This fixes 8 test cases from > test_escalations_volume.py test suite. > > > Changes: > 1) Moved account creation and VM deployment from setUpClass() to setUp() > 2) Fixed import * issues > 3) Fixed pep8 issues > > > Diffs > ----- > > test/integration/component/test_escalations_volumes.py db4c3d8 > > Diff: https://reviews.apache.org/r/25734/diff/ > > > Testing > ------- > > Yes. Ran whole test suite against KVM and all test cases passed. > > Log: > @summary: Test List Volumes pagination ... === TestName: > test_01_list_volumes_pagination | Status : SUCCESS === > ok > @summary: Test List Volumes with Id ... === TestName: > test_02_list_volume_byid | Status : SUCCESS === > ok > @summary: Test to verify creation and resize of data volume ... === TestName: > test_03_data_volume_resize | Status : SUCCESS === > ok > @summary: Test to verify creation and resize of custom volume ... === > TestName: test_04_custom_volume_resize | Status : SUCCESS === > ok > @summary: Test to verify creation of snapshot from volume and creation of > template, volume from snapshot ... === TestName: test_05_volume_snapshot | > Status : SUCCESS > === > ok > @summary: Test to verify creation of Hourly Snapshot policies from volume ... > === TestName: test_06_volume_snapshot_policy_hourly | Status : SUCCESS === > ok > @summary: Test to verify creation of Daily Snapshot policies from volume ... > === TestName: test_07_volume_snapshot_policy_daily | Status : SUCCESS === > ok > @summary: Test to verify creation of Weekly Snapshot policies from volume ... > === TestName: test_08_volume_snapshot_policy_weekly | Status : SUCCESS === > ok > @summary: Test to verify creation of Monthly Snapshot policies from volume > ... === TestName: test_09_volume_snapshot_policy_monthly | Status : SUCCESS > === > ok > @summary: Test to verify pagination of snapshots for Volume ... === TestName: > test_10_volume_snapshots_pagination | Status : SUCCESS === > ok > @summary: Test to verify extract/download a Volume ... === TestName: > test_11_volume_extract | Status : SUCCESS === > ok > @summary: Test to verify upload volume ... === TestName: > test_12_volume_upload | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 12 tests in 2657.038s > > OK > > > Thanks, > > Gaurav Aradhye > >
