-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25518/
-----------------------------------------------------------
(Updated Sept. 10, 2014, 10 p.m.)
Review request for cloudstack, edison su, Min Chen, Prachi Damle, and Santhosh
Edukulla.
Changes
-------
Corrected the error message check for
CloudstackAclException.NO_PERMISSION_TO_OPERATE_ACCOUNT instead of
CloudstackAclException.NO_PERMISSION_TO_ACCESS_ACCOUNT
Bugs: CLOUDSTACK-7035
https://issues.apache.org/jira/browse/CLOUDSTACK-7035
Repository: cloudstack-git
Description
-------
Test Suite contains ACL test cases relating to listNetworks() for isolated and
shared networks when executed by Admin, domain admin and resgular users.
Diffs (updated)
-----
test/integration/component/test_acl_listnetwork.py PRE-CREATION
Diff: https://reviews.apache.org/r/25518/diff/
Testing
-------
Tested this suite against a simulator set up from master:
Test listing of Networks by passing no parameters as domain admin ... ===
TestName: test_listNetwork_as_domainadmin | Status : FAILED ===
FAIL
Domain admin should not be allowed to list networks of accounts in other
domains ... === TestName: test_listNetwork_as_domainadmin_cross_domainid |
Status : SUCCESS ===
ok
Regular User should not be allowed to list networks of other accounts in other
domains ... === TestName:
test_listNetwork_as_domainadmin_cross_domainid_accountid | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId parameter as domain admin ... ===
TestName: test_listNetwork_as_domainadmin_domainid | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId and isrecursive=false parameter as
domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid__rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname parameter as domain
admin ... === TestName: test_listNetwork_as_domainadmin_domainid_accountid |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false and
isrecursive=false parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_false_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false and
isrecursive=true parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_false_rec_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true and
isrecursive=false parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_true_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true and
isrecursive=true parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_listall_true_rec_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname and isrecursive=false
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_rec_false | Status : SUCCESS
===
ok
Test listing of Networks by passing domainId ,accountname and isrecursive=true
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_accountid_rec_true | Status : SUCCESS
===
ok
Test listing of Networks by passing domainId ,listall=false parameter as domain
admin ... === TestName: test_listNetwork_as_domainadmin_domainid_listall_false
| Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false and
isrecursive=false parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_listall_false_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false and
isrecursive=true parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_listall_false_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId and listall=true parameter as
domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_listall_true | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=true and
isrecurisive=false parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_listall_true_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=truei and
isrecursive=false parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_listall_true_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId and isrecursive=true parameter as
domain admin ... === TestName:
test_listNetwork_as_domainadmin_domainid_true_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing listall="false" parameter as domain admin
... === TestName: test_listNetwork_as_domainadmin_listall_false | Status :
FAILED ===
FAIL
Test listing of Networks by passing listall="false",isrecursive="false"
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_listall_false_rec_false | Status : FAILED ===
FAIL
Test listing of Networks by passing listall="false",isrecursive="true"
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_listall_false_rec_true | Status : FAILED ===
FAIL
Test listing of Networks by passing listall="true" parameter as domain admin
... === TestName: test_listNetwork_as_domainadmin_listall_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing listall="true",isrecursive="false"
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_listall_true_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing listall="true" and isrecursive="true"
parameter as domain admin ... === TestName:
test_listNetwork_as_domainadmin_listall_true_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing isrecursive="false" parameter as domain
admin ... === TestName: test_listNetwork_as_domainadmin_rec_false | Status :
FAILED ===
FAIL
Test listing of Networks by passing isrecursive="true" parameter as domain
admin ... === TestName: test_listNetwork_as_domainadmin_rec_true | Status :
FAILED ===
FAIL
Test listing of Networks by passing no parameter as Regular User ... ===
TestName: test_listNetwork_as_regularuser | Status : SUCCESS ===
ok
Regular User should not be allowed to list networks of other accounts in other
domains ... === TestName: test_listNetwork_as_regularuser_cross_domainid |
Status : SUCCESS ===
ok
Regular User should not be allowed to list networks of other accounts in the
same domain ... === TestName:
test_listNetwork_as_regularuser_cross_domainid_accountid | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId parameter as Regular User ... ===
TestName: test_listNetwork_as_regularuser_domainid | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname parameter as Regular
User ... === TestName: test_listNetwork_as_regularuser_domainid_accountid |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false
,isrecursive=false parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_false_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname ,listall=false,
isrecursive=true parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_false_rec_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname ,
listall=true,isrecursive=false parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_true_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname ,
listall=true,isrecursive=true parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_listall_true_rec_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , isrecursive=false
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_rec_false | Status : SUCCESS
===
ok
Test listing of Networks by passing domainId ,accountname , isrecursive=true
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_accountid_rec_true | Status : SUCCESS
===
ok
Test listing of Networks by passing domainId ,listall=false parameter as
Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_listall_false | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId , listall=false, isrecursive=false
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_listall_false_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false, isrecursive=true
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_listall_false_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=true parameter as Regular
User ... === TestName: test_listNetwork_as_regularuser_domainid_listall_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId , listall=true, isrecursive=false
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_listall_true_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=true, isrecursive=true
parameter as Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_listall_true_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId, isrecursive=false parameter as
Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId , isrecursive=true parameter as
Regular User ... === TestName:
test_listNetwork_as_regularuser_domainid_true_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing listall, isrecursive=false parameter as
Regular User ... === TestName: test_listNetwork_as_regularuser_listall_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing listall=false , isrecursive=false parameter
as Regular User ... === TestName:
test_listNetwork_as_regularuser_listall_false_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing listall=false , isrecursive=true parameter
as Regular User ... === TestName:
test_listNetwork_as_regularuser_listall_false_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing listall=true parameter as Regular User ...
=== TestName: test_listNetwork_as_regularuser_listall_true | Status : SUCCESS
===
ok
Test listing of Networks by passing listall=true, isrecursive=false parameter
as Regular User ... === TestName:
test_listNetwork_as_regularuser_listall_true_rec_false | Status : SUCCESS ===
ok
test_listNetwork_as_regularuser_listall_true_rec_true
(integration.component.test_acl_listnetwork.TestNetworkList) ... === TestName:
test_listNetwork_as_regularuser_listall_true_rec_true | Status : SUCCESS ===
ok
test_listNetwork_as_regularuser_rec_false
(integration.component.test_acl_listnetwork.TestNetworkList) ... === TestName:
test_listNetwork_as_regularuser_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing isrecursive=true parameter as Regular User
... === TestName: test_listNetwork_as_regularuser_rec_true | Status : SUCCESS
===
ok
Test listing of Networks by passing no parameter as domain admin ... ===
TestName: test_listNetwork_as_rootadmin | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId parameter as ROOT admin ... ===
TestName: test_listNetwork_as_rootadmin_domainid | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname parameter as ROOT
admin ... === TestName: test_listNetwork_as_rootadmin_domainid_accountid |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false
parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname ,
listall=false,isrecurisve=false parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_false_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=false,
isrecursive=true parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_false_rec_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true
parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true,
isrecursive=true parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_true_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , listall=true
,isrecrsive=true parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_listall_true_rec_true | Status
: SUCCESS ===
ok
Test listing of Networks by passing domainId ,accountname , isrecursive=false
parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_rec_false | Status : SUCCESS
===
ok
test_listNetwork_as_rootadmin_domainid_accountid_rec_true
(integration.component.test_acl_listnetwork.TestNetworkList) ... === TestName:
test_listNetwork_as_rootadmin_domainid_accountid_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false parameter as ROOT
admin ... === TestName: test_listNetwork_as_rootadmin_domainid_listall_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false , isrecursive=false
parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_listall_false_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=false, isrecursive=true
parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_listall_false_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId and listall=true parameter as ROOT
admin ... === TestName: test_listNetwork_as_rootadmin_domainid_listall_true |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=true and
isrecurisive=false parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_listall_true_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing domainId ,listall=truei and
isrecursive=false parameter as ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_listall_true_rec_true | Status : SUCCESS
===
ok
Test listing of Networks by passing domainId , isrecursive=false parameter as
ROOT admin ... === TestName: test_listNetwork_as_rootadmin_domainid_rec_false |
Status : SUCCESS ===
ok
Test listing of Networks by passing domainId , isrecursive=true parameter as
ROOT admin ... === TestName:
test_listNetwork_as_rootadmin_domainid_true_rec_true | Status : SUCCESS ===
ok
Test listing of Networks by passing listall="false" parameter as domain admin
... === TestName: test_listNetwork_as_rootadmin_listall_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing listall="false", isrecursive=false
parameter as domain admin ... === TestName:
test_listNetwork_as_rootadmin_listall_false_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing listall="false" , isrecursive=true
parameter as domain admin ... === TestName:
test_listNetwork_as_rootadmin_listall_false_rec_true | Status : FAILED ===
FAIL
Test listing of Networks by passing listall="true" parameter as ROOT admin ...
=== TestName: test_listNetwork_as_rootadmin_listall_true | Status : SUCCESS ===
ok
Test listing of Networks by passing listall="true" parameter as ROOT admin ...
=== TestName: test_listNetwork_as_rootadmin_listall_true_rec_false | Status :
SUCCESS ===
ok
Test listing of Networks by passing listall="true" parameter as ROOT admin ...
=== TestName: test_listNetwork_as_rootadmin_listall_true_rec_true | Status :
SUCCESS ===
ok
Test listing of Networks by passing isrecursive=false parameter as domain admin
... === TestName: test_listNetwork_as_rootadmin_rec_false | Status : SUCCESS ===
ok
Test listing of Networks by passing isrecursive=true parameter as domain admin
... === TestName: test_listNetwork_as_rootadmin_rec_true | Status : FAILED ===
FAIL
Domain admin should be able to list networks that is owned by any account in
his domain by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_domainadmin_ownedbyusersindomain | Status : SUCCESS
===
ok
Domain admin should be able to list networks that is owned by any account in
his sub-domain by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_domainadmin_ownedbyusersinsubdomain | Status : FAILED
===
FAIL
Domain admin should be able to list networks that is owned by account that is
in his sub domains by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status :
FAILED ===
FAIL
Domain admin should not be able to list networks that is owned by account that
is not in his domain by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_domainadmin_ownedbyusersnotindomain | Status :
SUCCESS ===
ok
Domain admin should be able to list networks that he owns by passing uuid in
"id" parameter ... === TestName: test_listNetwork_by_id_as_domainadmin_owns |
Status : SUCCESS ===
ok
ROOT admin should be able to list Volumes that is owned by account that is in
his sub domains by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_rootadmin_Vmsownedbyothers | Status : FAILED ===
FAIL
ROOT admin should be able to list networks that is owned by account in his
domain by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_rootadmin_owns | Status : SUCCESS ===
ok
Regular user should be able to list Volumes that is owned by him by passing
uuid in "id" parameter ... === TestName: test_listNetwork_by_id_as_user_own |
Status : SUCCESS ===
ok
Regular user should not be able to list networks that is owned by different
account in the same domain by passing uuid in "id" parameter ... === TestName:
test_listNetwork_by_id_as_user_vmfromsamedomaindifferentaccount | Status :
SUCCESS ===
ok
Regular user should not be able to list networks that is owned by different
account in the different domain by passing uuid in "id" parameter ... ===
TestName: test_listNetwork_by_id_as_user_vmsfromotherdomain | Status : SUCCESS
===
ok
Ran 95 tests in 147.009s
FAILED (failures=11)
Following bugs have been logged to track the 11 failures seen in this run:
CLOUDSTACK-6974 - IAM-Root Admin - When listNetwork is used with listall=false
(or no listall passed), all isoalted networks belonging to other users is
listed.
CLOUDSTACK-6973 -I AM - listNetworks - When Domain Admin calls listNetwork with
listall=false , isolated networks belonging to other users in the domain is
also listed.
CLOUDSTACK-6939 - IAM - DomainAdmin - Not able to listNetwork belonging to a
subdomain by passing uuid.
CLOUDSTACK-6937- IAM - ROOT admin - Not able to list network owned by accounts
under any domain by passing uuid.
Thanks,
sangeetha hariharan
