On Sep 10, 2014, at 2:41 PM, sebgoa <run...@gmail.com> wrote: > > On Sep 10, 2014, at 2:36 PM, Rohit Yadav <rohit.ya...@shapeblue.com> wrote: > >> >> On 10-Sep-2014, at 2:20 pm, sebgoa <run...@gmail.com> wrote: >> >>> I am still confused by this one. The release build script removed the >>> -SNAPSHOT from deps/XenServer/pom.xml see: >>> >>> https://github.com/apache/cloudstack/commit/41c0eaa14d2f8cd5b58bca71f2254c2390cc6913#diff-03d0955964f7b3c8fddf550c9ffa1aeaL28 >>> >>> But your fix was in the root pom.xml to remove the -SNAPSHOT as well >>> >>> https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=pom.xml;h=83b62e2d4c1eb9d69d4802259d1203c71ca58eab;hp=19e4d35f32c1a516c71bd777dfdda51ab9c65ba2;hb=b6ee5e6455176e75c67b74241b1a9f6160cc62a1;hpb=33911723f851fe9a816c400bb4739539b8087cd3 >>> >>> But animesh added it back in Jan 22: >>> >>> https://github.com/apache/cloudstack/commit/361aaca794fd885d0b72573a89ad8799bdef301a >>> >>> So which one is correct for the Xapi artifact ? >> >> Alright, the way maven and dependencies work is that when you build an >> artifact/jar they get a version and to use this jar we have to specify the >> same version in dependency block. In this case the xapi jar >> (deps/XenServerJava) has some version and we need to use the same version in >> xen hypervisor plugin (plugins/hypervisor/xen/pom.xml) which pick the >> version string from root pom.xml. So, as long as these versions are same at >> both places, it does not matter whether you want to append some prefix since >> we’re consuming the artifact we build from deps/XenServer. >> > > Ok thanks for the explanation, I just would like confirmation that we should > not have the -SNAPSHOT > >> To make this less confusing, I’ve reverted my fix and made the pom in >> deps/XenServerJava to use -SNAPSHOT suffix like it was before. >> > > I think you went too fast, there is no need to revert it if that's correct. > The build script will remove the -SNAPSHOT from the > deps/XenServerJava/pom.xml, so it seems the way to avoid this in the future > is really to remove the -SNAPSHOT… >
Found the proper fix in 4.4 from Daan: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=blobdiff;f=tools/build/build_asf.sh;h=ea9b272d1d32a107ce06362efb163b6295969be1;hp=72f2111c303abe36f299d8f6a882a34439e33103;hb=58a4c7a89158ece348d890774c866e02f52e5d80;hpb=7fe353d4995a2b55c7baed5e27056dd2e2f7509f Even though if we don't use -SNAPSHOT for this artifact in the first place, we should never face the issue…:( > > >> Regards, >> Rohit Yadav >> Software Architect, ShapeBlue >> M. +41 779015219 | rohit.ya...@shapeblue.com >> Blog: bhaisaab.org | Twitter: @_bhaisaab >> >> Find out more about ShapeBlue and our range of CloudStack related services >> >> IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> >> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> >> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> >> CloudStack Infrastructure >> Support<http://shapeblue.com/cloudstack-infrastructure-support/> >> CloudStack Bootcamp Training >> Courses<http://shapeblue.com/cloudstack-training/> >> >> This email and any attachments to it may be confidential and are intended >> solely for the use of the individual to whom it is addressed. Any views or >> opinions expressed are solely those of the author and do not necessarily >> represent those of Shape Blue Ltd or related companies. If you are not the >> intended recipient of this email, you must neither take any action based >> upon its contents, nor copy or show it to anyone. Please contact the sender >> if you believe you have received this email in error. Shape Blue Ltd is a >> company incorporated in England & Wales. ShapeBlue Services India LLP is a >> company incorporated in India and is operated under license from Shape Blue >> Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil >> and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a >> company registered by The Republic of South Africa and is traded under >> license from Shape Blue Ltd. ShapeBlue is a registered trademark. >
