----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25474/#review52839 -----------------------------------------------------------
Ship it! Thanks for this followup patch. pushed to master 81d5dd9bcda185ff83820f8dd6233cf80f8efaed - SrikanteswaraRao Talluri On Sept. 9, 2014, 12:17 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25474/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:17 p.m.) > > > Review request for cloudstack, sanjeev n, Santhosh Edukulla, and > SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-7519 > https://issues.apache.org/jira/browse/CLOUDSTACK-7519 > > > Repository: cloudstack-git > > > Description > ------- > > As suggested in RR: https://reviews.apache.org/r/25433/ > > test_templates.py file has many instances where direct APIs are called from > the test case. Instead we have the methods in base library that can be used. > > > Diffs > ----- > > test/integration/smoke/test_templates.py b7fe49d > tools/marvin/marvin/lib/base.py 2a763ce > > Diff: https://reviews.apache.org/r/25474/diff/ > > > Testing > ------- > > Yes. > > Tested on KVM setup. > > Log: > Test create public & private template ... === TestName: > test_01_create_template | Status : SUCCESS === > ok > Test Edit template ... === TestName: test_02_edit_template | Status : SUCCESS > === > ok > Test delete template ... === TestName: test_03_delete_template | Status : > SUCCESS === > ok > Test for extract template ... === TestName: test_04_extract_template | Status > : SUCCESS === > ok > Update & Test for template permissions ... === TestName: > test_05_template_permissions | Status : SUCCESS === > ok > Test for copy template from one zone to another ... === TestName: > test_06_copy_template | Status : SUCCESS === > ok > Test only public templates are visible to normal user ... === TestName: > test_07_list_public_templates | Status : SUCCESS === > ok > Test System templates are not visible to normal user ... === TestName: > test_08_list_system_templates | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 8 tests in 1007.401s > > OK > > > Thanks, > > Gaurav Aradhye > >
