----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22705/#review52530 -----------------------------------------------------------
Ship it! Looks good to me. - Min Chen On Sept. 5, 2014, 7:02 p.m., sangeetha hariharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22705/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 7:02 p.m.) > > > Review request for cloudstack, edison su, Min Chen, Prachi Damle, and > Santhosh Edukulla. > > > Repository: cloudstack-git > > > Description > ------- > > This test suite contains test cases relating to access checks for > listVirtualMachine() with parameters - id,listall,isrecursive,account and > domainid executed as ROOT admin,domain admin and regular users. > > > Diffs > ----- > > test/integration/component/test_acl_listvm.py PRE-CREATION > > Diff: https://reviews.apache.org/r/22705/diff/ > > > Testing > ------- > > Executed test suite against the latest 4.4-forward management server using a > simulator set up: > > test_listVM_as_domainadmin (integration.component.test_acl_listvm.TestVMList) > ... === TestName: test_listVM_as_domainadmin | Status : SUCCESS === > ok > test_listVM_as_domainadmin_cross_domainid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_cross_domainid | Status : SUCCESS === > ok > test_listVM_as_domainadmin_cross_domainid_accountid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_cross_domainid_accountid | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_false | Status : > SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_false | > Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_false_rec_true | Status > : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_true | Status : SUCCESS > === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_false | Status > : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_listall_true_rec_true | Status > : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_rec_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_accountid_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_accountid_rec_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_false_rec_false | Status : > SUCCESS === > ok > test_listVM_as_domainadmin_domainid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_false_rec_true | Status : SUCCESS > === > ok > test_listVM_as_domainadmin_domainid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_true_rec_false | Status : SUCCESS > === > ok > test_listVM_as_domainadmin_domainid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_listall_true_rec_true | Status : SUCCESS > === > ok > test_listVM_as_domainadmin_domainid_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_rec_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_domainid_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_domainid_rec_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_false_rec_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_false_rec_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_true_rec_false | Status : SUCCESS === > ok > test_listVM_as_domainadmin_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_listall_true_rec_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_rec_true | Status : SUCCESS === > ok > test_listVM_as_domainadmin_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_domainadmin_true_rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser (integration.component.test_acl_listvm.TestVMList) > ... === TestName: test_listVM_as_regularuser | Status : SUCCESS === > ok > test_listVM_as_regularuser_cross_domainid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_cross_domainid | Status : SUCCESS === > ok > test_listVM_as_regularuser_cross_domainid_accountid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_cross_domainid_accountid | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid__rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid__rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_false | Status : > SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_false_rec_false | > Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_false_rec_true | Status > : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_true | Status : SUCCESS > === > ok > test_listVM_as_regularuser_domainid_accountid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_true_rec_false | Status > : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_listall_true_rec_true | Status > : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_accountid_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_accountid_rec_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_false_rec_false | Status : > SUCCESS === > ok > test_listVM_as_regularuser_domainid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_false_rec_true | Status : SUCCESS > === > ok > test_listVM_as_regularuser_domainid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_domainid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_true_rec_false | Status : SUCCESS > === > ok > test_listVM_as_regularuser_domainid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_listall_true_rec_true | Status : SUCCESS > === > ok > test_listVM_as_regularuser_domainid_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_domainid_true_rec_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_false_rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_false_rec_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_true_rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_listall_true_rec_true | Status : SUCCESS === > ok > test_listVM_as_regularuser_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_rec_false | Status : SUCCESS === > ok > test_listVM_as_regularuser_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_regularuser_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin (integration.component.test_acl_listvm.TestVMList) > ... === TestName: test_listVM_as_rootadmin | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_false | Status : SUCCESS > === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_false_rec_false | Status > : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_false_rec_true | Status : > SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_true | Status : SUCCESS > === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_true_rec_false | Status : > SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_listall_true_rec_true | Status : > SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_rec_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_accountid_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_accountid_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_false_rec_false | Status : SUCCESS > === > ok > test_listVM_as_rootadmin_domainid_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_false_rec_true | Status : SUCCESS > === > ok > test_listVM_as_rootadmin_domainid_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_true_rec_false | Status : SUCCESS > === > ok > test_listVM_as_rootadmin_domainid_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_listall_true_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_rec_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_domainid_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_domainid_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_false_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_false_rec_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_false_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_false_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_true_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_true_rec_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_listall_true_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_listall_true_rec_true | Status : SUCCESS === > ok > test_listVM_as_rootadmin_rec_false > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_rec_false | Status : SUCCESS === > ok > test_listVM_as_rootadmin_rec_true > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_as_rootadmin_rec_true | Status : SUCCESS === > ok > test_listVM_by_id_as_domainadmin_ownedbyusersindomain > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_domainadmin_ownedbyusersindomain | Status : SUCCESS === > ok > test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain | Status : SUCCESS > === > ok > test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain2 > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_domainadmin_ownedbyusersinsubdomain2 | Status : SUCCESS > === > ok > test_listVM_by_id_as_domainadmin_ownedbyusersnotindomain > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_domainadmin_ownedbyusersnotindomain | Status : SUCCESS > === > ok > test_listVM_by_id_as_domainadmin_owns > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_domainadmin_owns | Status : SUCCESS === > ok > test_listVM_by_id_as_rootadmin_Vmsownedbyothers > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_rootadmin_Vmsownedbyothers | Status : SUCCESS === > ok > test_listVM_by_id_as_rootadmin_owns > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_rootadmin_owns | Status : SUCCESS === > ok > test_listVM_by_id_as_user_own > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_user_own | Status : SUCCESS === > ok > test_listVM_by_id_as_user_vmfromsamedomaindifferentaccount > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_user_vmfromsamedomaindifferentaccount | Status : SUCCESS > === > ok > test_listVM_by_id_as_user_vmsfromotherdomain > (integration.component.test_acl_listvm.TestVMList) ... === TestName: > test_listVM_by_id_as_user_vmsfromotherdomain | Status : SUCCESS === > ok > > ---------------------------------------------------------------------- > Ran 95 tests in 134.796s > > OK > > > Thanks, > > sangeetha hariharan > >
