----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25170/#review52284 -----------------------------------------------------------
Ship it! applied to master with 355eb72c7d3a3bf29d6d1a2185a5973bc511ed77 and applied to hotfix/4.4-7405 It did not apply cleanly on 4.3, so I will not apply it there and keep it at Erik's patch in vmdata.py thanks for the patch, you can mark the review as submitted - Sebastien Goasguen On Aug. 28, 2014, 10:46 p.m., Fred Clift wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25170/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 10:46 p.m.) > > > Review request for cloudstack. > > > Bugs: 7405 > https://issues.apache.org/jira/browse/7405 > > > Repository: cloudstack-git > > > Description > ------- > > pre-add all RewriteRule entries to metadata htaccess file for system vm > routers- makes automated router maintanince easier... The set is static and > doesn't ever change after the initial provision - it is identical for every > router... > > Fix htaccess file, vmdata.py that used to modify it, and added comments to > producers of meta-data to note the new usage > > Includes updated fix for bug 7405 > > We (betterservers.com) have some in-house router-fixing scripts that would > like to re-unpack the tarball and not loose the full .htaccess file... > > > Diffs > ----- > > > core/test/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResourceTest.java > aab1e72 > > plugins/hypervisors/baremetal/src/com/cloud/baremetal/networkservice/BaremetalPxeManagerImpl.java > e133f7d > server/src/com/cloud/network/element/CloudZonesNetworkElement.java 55cd5fa > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 33d7cd7 > systemvm/patches/debian/config/opt/cloud/bin/vmdata.py a44c134 > systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9 > > Diff: https://reviews.apache.org/r/25170/diff/ > > > Testing > ------- > > tested before and after getting user-data and metadata, with and without > trailing slashes. > > provisioned new router. > > > Thanks, > > Fred Clift > >
