Thanks for looking into it, You did not have to revert the commit, I was just pointing out that it did not seem to have fixed the issue, and that it would be good to get in the habit of testing in our own forks before committing to master.
-sebastien On Sep 4, 2014, at 3:53 AM, Sailaja Mada <sailaja.m...@citrix.com> wrote: > Hi, > > I have reverted the commit. I will recheck locally and commit the fix. > > Thanks, > Sailaja.M > > -----Original Message----- > From: Sebastien Goasguen [mailto:run...@gmail.com] > Sent: 04 September 2014 12:53 > To: dev@cloudstack.apache.org; Sailaja Mada > Subject: Test VM life Cycle > > Hi Sailaja, > > Looks like you just committed this: > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=aa4fea231db714f369f0ec5203a9407c98152984 > > To fix the test_vm_life_cycle test, that's great but I don't think it works. > > With Travis now running the tests for every commit we see that one set of > tests is still red: > https://travis-ci.org/apache/cloudstack/builds/34359983 > > And indeed it seems to be this vm life cycle test that is failing. > > Ideally, you could fork cloudstack on github, make the commit, travis would > run the tests on your own fork and once it's "green" you can push to master. > > Could you have another look at it ? > > thanks, > > PS: there might still be issues with the config on travis but from my > experience yesterday on 4.3, if it fails on travis, it's also failing locally. > > -sebastien
