> On Sept. 3, 2014, 9:32 a.m., Rajani Karuturi wrote:
> > client/tomcatconf/classpath.conf.in, line 37
> > <https://reviews.apache.org/r/25289/diff/1/?file=674877#file674877line37>
> >
> >     Can we get the JAVA_HOME from installed java instead of hardcoding it? 
> > The path may be different for different os versions or distributions. 
> >     
> >     something similar to what we already did at 
> > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=c468228fe807c621decc5919dadae9bcbb38c753
> >     
> >     May we should move this to a common file like setenv.sh and use it 
> > everywhere.

+1


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25289/#review52151
-----------------------------------------------------------


On Sept. 3, 2014, 6:25 a.m., Rayees Namathponnan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25289/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 6:25 a.m.)
> 
> 
> Review request for cloudstack, Frank Zhang and Hugo Trippaers.
> 
> 
> Bugs: CLOUDSTACK-7474
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7474
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Step 1: Deploy new RHEL 6.3 machine
> Step 2 : Install MS
> Step 3: run deploy script and start MS
> 
> Result 
> 
> Installation completed successfully,  both java7 and java got installed as 
> part of MS installation, but MS failed to start java version erro
> 
> we need to load java7 while start MS
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/classpath.conf.in 3ae0fb4 
> 
> Diff: https://reviews.apache.org/r/25289/diff/
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Rayees Namathponnan
> 
>

Reply via email to