----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25235/#review52023 -----------------------------------------------------------
1. It should be possible to refactor these tests to put code into functions - at present there is a lot of duplicated code between each testcase 2. Additional validation should be performed either in the guest or on the XenServer host to validate that the correct vGPU has been attached 3. Validation should be performed after the first VM has been deployed, mostly so that if the testcase fails, it's clear whether it also failed on the first service offering. - John Dilley On Sept. 1, 2014, 5:34 p.m., sailaja mada wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25235/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2014, 5:34 p.m.) > > > Review request for cloudstack, Doug Clark, John Dilley, and Sanjay Tripathi. > > > Repository: cloudstack-git > > > Description > ------- > > vGPU service offering upgrade test automation > > > Diffs > ----- > > test/integration/component/test_deploy_vgpu_vm.py 534a7e3 > > Diff: https://reviews.apache.org/r/25235/diff/ > > > Testing > ------- > > Yes. All the testcases are passed with XenServer. > > > Thanks, > > sailaja mada > >
