> On Aug. 27, 2014, 4:50 a.m., Sebastien Goasguen wrote: > > Hi Fred, thanks for looking into this. I already applied Erik's review from > > https://reviews.apache.org/r/25023/ > > I am happy to apply yours if you think it makes sense. > > > > We just need to make sure it indeed fixes the problem and applies on 4.3, > > 4.4 and master.
I think my patch, as it stands, will mostly invalidate/break Eric's patch - I'll do a pull, and remake my patch. To be honest, I'm not sure why we dynamically generate /var/www/htdocs/latest/.htaccess dynamically anyway. It may be a holdover from some past refactoring. Anyway, I'll have somthing today. - Fred ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25065/#review51648 ----------------------------------------------------------- On Aug. 26, 2014, 11:07 a.m., Fred Clift wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25065/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 11:07 a.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > pre-add all RewriteRule entries to metadata htaccess file for system vm > routers- makes automated router maintanince easier... The set is static and > doesn't ever change after the initial provision - it is identical for every > router... While it is probably good to have code that can dynamically add new > lines (opt/cloud/bin/vmdata.py currently does this, starting from the stub in > git now) there is no reason not to have the full static set of rules in the > initial file. We (betterservers.com) have some in-house router-fixing > scripts that would like to re-unpack the tarball and not loose the full > .htaccess file... > > > Diffs > ----- > > systemvm/patches/debian/config/var/www/html/latest/.htaccess 038a4c9 > > Diff: https://reviews.apache.org/r/25065/diff/ > > > Testing > ------- > > installed cloudstack, set up networks and provisioned a vm - made sure the > router got the same .htaccess file that it would normally get after the first > vm is added to the network > > > Thanks, > > Fred Clift > >
