> On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote: > > test/integration/component/test_dedicate_public_ip_range.py, line 920 > > <https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line920> > > > > What is the need for acquiring ip address here? Not deploying any vms > > in the netowrk so why do we need IP address for source nat?
I will be working on this patch. Apparently we can't add a guest network without source nat, the network offering does not list out when we try to create a network with network offering which does not provide source nat. And when the source nat service is enabled for a network, the first public IP acquired is used for source nat and we can't disassociate it. > On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote: > > test/integration/component/test_dedicate_public_ip_range.py, line 1080 > > <https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line1080> > > > > Add code to verify the ip range release is success or not. Will do. I will add the patch with review changes through my account. - Ashutosh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23819/#review50869 ----------------------------------------------------------- On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23819/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 5:52 p.m.) > > > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri. > > > Bugs: CLOUDSTACK-2251 > https://issues.apache.org/jira/browse/CLOUDSTACK-2251 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant > feature > > > Diffs > ----- > > test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION > tools/marvin/marvin/config/test_data.py 3cd4b6c > tools/marvin/marvin/lib/base.py 1a32275 > > Diff: https://reviews.apache.org/r/23819/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Girish Shilamkar > >
