Hi Sebastien, On 26-Aug-2014, at 10:38 am, Sebastien Goasguen <run...@gmail.com> wrote: > What's the unit test coverage ?
Class, %Method, %Line, % SAMLUtils100% (1/ 1)80% (8/ 10)75% (66/ 88) SAML2UserAuthenticator100% (1/ 1)100% (4/ 4)84.6% (11/ 13) SAML2LoginAPIAuthenticatorCmd100% (1/ 1)45.5% (5/ 11)50.8% (63/ 124) SAML2LoginAPIAuthenticatorCmdTest100% (1/ 1)100% (4/ 4)98.6% (72/ 73) SAML2LogoutAPIAuthenticatorCmd100% (1/ 1)62.5% (5/ 8)35.3% (18/ 51) SAML2LogoutAPIAuthenticatorCmdTest100% (1/ 1)100% (3/ 3)100% (26/ 26) SAML2AuthManagerImpl0% (0/ 1)0% (0/ 12)0% (0/ 60) (The last one, auth manager is an adapter which is injected by Spring to an api auth manager, the start() method of which depends on fetching metadata from external IdP so may not be unit tested). Existing contract of ApiServlet and other classes and their external interfaces have not changed. ApiServlet’s test cases were fixed. > Can you add some Marvin/integration tests ? Depends on external entity, IdP, will be difficult to write and I don’t know how. The saml plugin’s external operation consists of redirecting user to IdP for authentication when samlsso or samlslo apis are called. Selenium tests could be written but we don’t have any such infra or existing tests yet. Regards, Rohit Yadav Software Architect, ShapeBlue M. +41 779015219 | rohit.ya...@shapeblue.com Blog: bhaisaab.org | Twitter: @_bhaisaab Find out more about ShapeBlue and our range of CloudStack related services IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/> This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark.
