----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25023/#review51392 -----------------------------------------------------------
Ship it! even though Wido pushed the same fix to master, I applied your patch to 4.3 :) ac04e6d97ec9e3afeb16937402efbd306fdccae9 thanks, you can mark the review as submitted - Sebastien Goasguen On Aug. 25, 2014, 12:05 p.m., Erik Weber wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25023/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 12:05 p.m.) > > > Review request for cloudstack and Marcus Sorensen. > > > Bugs: CLOUDSTACK-7405 > https://issues.apache.org/jira/browse/CLOUDSTACK-7405 > > > Repository: cloudstack-git > > > Description > ------- > > As per https://issues.apache.org/jira/browse/CLOUDSTACK-7405 cloud-init > expects to be able to get meta-data directory without using a trailing slash. > > Ultimately this should be fixed in cloud-init, but it's an unintrusive fix in > cloudstack > > > Diffs > ----- > > systemvm/patches/debian/config/opt/cloud/bin/vmdata.py f508032 > > Diff: https://reviews.apache.org/r/25023/diff/ > > > Testing > ------- > > tested with curl that both new and old url works > > [root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data/vm-id | grep HTTP > HTTP/1.1 200 OK > [root@jenkins ~]# curl -I -s 10.30.81.1/latest/meta-data | grep HTTP > HTTP/1.1 200 OK > > > Thanks, > > Erik Weber > >