----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24444/#review50859 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On Aug. 7, 2014, 6:13 a.m., Anshul Gangwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24444/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 6:13 a.m.) > > > Review request for cloudstack, Devdeep Singh and Rajesh Battala. > > > Bugs: CLOUDSTACK-7277 > https://issues.apache.org/jira/browse/CLOUDSTACK-7277 > > > Repository: cloudstack-git > > > Description > ------- > > For vmsync first VMs are listed and than their power state is determined. > To exclude hosted system we filter the result on Caption='Virtual Machine' > but this string is locale dependent so it may not > not work properly for locales other than english. To overcome this now we > started using ProcessId >= 0 filter > > > Diffs > ----- > > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/HypervResourceController.cs > 195a964 > > plugins/hypervisors/hyperv/DotNet/ServerResource/HypervResource/WmiCallsV2.cs > b2a7b45 > > Diff: https://reviews.apache.org/r/24444/diff/ > > > Testing > ------- > > tested on my local system with ProcessId >= 0 filter VMs are syncing up > properly > > > Thanks, > > Anshul Gangwar > >
