----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23610/#review50185 -----------------------------------------------------------
test/integration/component/test_shared_networks.py <https://reviews.apache.org/r/23610/#comment87789> remove sanj test/integration/component/test_shared_networks.py <https://reviews.apache.org/r/23610/#comment87788> Use validatelist if possible for easy reading test/integration/component/test_shared_networks.py <https://reviews.apache.org/r/23610/#comment87791> same here and at other places, it will reduce no of lines - Santhosh Edukulla On Aug. 11, 2014, 5:38 a.m., sanjeev n wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23610/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 5:38 a.m.) > > > Review request for cloudstack, Santhosh Edukulla and SrikanteswaraRao Talluri. > > > Bugs: cs-4282 > https://issues.apache.org/jira/browse/cs-4282 > > > Repository: cloudstack-git > > > Description > ------- > > Adding new script for verifying multiple shared networks support with > overlapped cidrs in different vlans. > 1.Create network1 with cidr1 and vlan1--pass > 2.Create network2 with cidr1 and vlan1--fails > 3.Create network3 with cidr1 and vlan2- pass > > > Diffs > ----- > > test/integration/component/test_shared_networks.py f99bfbf > > Diff: https://reviews.apache.org/r/23610/diff/ > > > Testing > ------- > > yes > > > Thanks, > > sanjeev n > >
