----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22939/#review50114 -----------------------------------------------------------
Would it be better to fix/figure out why disk.getFormat() returns QCOW2 for CLVM? We are manually fixing it here, but it seems that could cause other problems elsewhere if getFormat doesn't work for CLVM due to some enum elsewhere or something that is incorrectly configured. - Marcus Sorensen On Aug. 8, 2014, 4:51 p.m., Simon Weller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22939/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 4:51 p.m.) > > > Review request for cloudstack, edison su and Marcus Sorensen. > > > Bugs: CLOUDSTACK-6460 > https://issues.apache.org/jira/browse/CLOUDSTACK-6460 > > > Repository: cloudstack-git > > > Description > ------- > > Addresses CLOUDSTACK-6460. > CLVM storage source was being identified as QCOW2, rather than raw when > attempting a primary storage migration. This caused the migration to fail > when qemu-img attempted to image the file back from secondary storage to the > new primary storage selected. This patch forces CLVM to be treated as RAW > while continuing to acquire sourceFormat from other storage types via > disk.getFormat(); > > > Diffs > ----- > > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java > e9c588e > > Diff: https://reviews.apache.org/r/22939/diff/ > > > Testing > ------- > > Stop VM. Migrate from one primary storage to another. Migration completes > successfully. Start vm. > > > Thanks, > > Simon Weller > >
