----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24378/#review49885 -----------------------------------------------------------
Commit 7ff7e9cf5ae4d5ababa0bf7e7ccb4a8cb1064045 in cloudstack's branch refs/heads/master from John Dilley [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7ff7e9c ] CLOUDSTACK-7268: Ignore "already exists" error in createEgressFirewallRule Signed-off-by: Santhosh Edukulla <santhosh.eduku...@gmail.com> - ASF Subversion and Git Services On Aug. 7, 2014, 7:41 a.m., John Dilley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24378/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2014, 7:41 a.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7268 > https://issues.apache.org/jira/browse/CLOUDSTACK-7268 > > > Repository: cloudstack-git > > > Description > ------- > > Although we could search for an existing firewall rule, this fix is simpler, > and also less prone to race conditions if multiple threads are running. > > > Diffs > ----- > > tools/marvin/marvin/lib/base.py 3a1f7e6 > > Diff: https://reviews.apache.org/r/24378/diff/ > > > Testing > ------- > > Tested on KVM advanced zone > > > Thanks, > > John Dilley > >
