----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24314/#review49757 -----------------------------------------------------------
I tested the flow and it looks good to me. I did review the code but best to have a UI expert to take a look as well. - Nitin Mehta On Aug. 5, 2014, 9:03 p.m., Mihaela Stoica wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24314/ > ----------------------------------------------------------- > > (Updated Aug. 5, 2014, 9:03 p.m.) > > > Review request for cloudstack, Brian Federle, Jessica Wang, and Nitin Mehta. > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-6695: Added support to the UI for uploading a chain of certificates > > In the "SSL Certificate" dialog we added: > - new field for the root certificate; > - a button to add intermediate certificates if necessary; when this is > pressed, a new field, called "Intermediate certificate 1" is added; pressed > again, "Intermediate certificate 2" field is added, and so on. > > We upload the certificates in order: first the root certificate (with id=1), > then the intermediate certificates (with id=2,3,..) and finally the server > certificate. > When uploading a certificate, we wait for the upload to be completed > succesfully and only then we proceed to uploading the next one. If one fails, > we report failure and don't continue with the remaining. > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties a0205e1 > ui/css/cloudstack3.css 23681a7 > ui/dictionary.jsp 10aeaf9 > ui/scripts/ui-custom/physicalResources.js ac379b4 > > Diff: https://reviews.apache.org/r/24314/diff/ > > > Testing > ------- > > Yes, with a sample certificate chain. > > > Thanks, > > Mihaela Stoica > >
