----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24298/#review49732 -----------------------------------------------------------
test/integration/smoke/misc/test_deploy_vm.py <https://reviews.apache.org/r/24298/#comment87042> Generally, how does putting these test in a separate directory help? Doesn't nosetests recursively search for tests. test/integration/smoke/misc/test_deploy_vm.py <https://reviews.apache.org/r/24298/#comment87041> In the previous comment an exception in tearDown resulted in an exception being raised - here we just output a debug to the logs - can we make this consistent? test/integration/smoke/test_vm_life_cycle.py <https://reviews.apache.org/r/24298/#comment87040> What is the advantage of catching an exception only to immediately re-raise it? Will the stack trace for the original exception still appear in the logs? - Doug Clark On Aug. 6, 2014, 12:33 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24298/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2014, 12:33 p.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-6873 > https://issues.apache.org/jira/browse/CLOUDSTACK-6873 > > > Repository: cloudstack-git > > > Description > ------- > > The tests in test suites test_deploy_vm.py and test_vm_ha.py need to be run > serially, hence moved them to misc folder. > Also tagged the tests as "required_hardware='simulator only'" which require > to be run only on simulator. > > Moved the normal tests (for which above criteria don't apply) from > test_deploy_vm.py to test_vm_life_cycle.py in smoke folder. > > > Diffs > ----- > > test/integration/smoke/misc/__init__.py PRE-CREATION > test/integration/smoke/misc/test_deploy_vm.py PRE-CREATION > test/integration/smoke/misc/test_vm_ha.py PRE-CREATION > test/integration/smoke/test_deploy_vm.py 29cdb96 > test/integration/smoke/test_vm_ha.py c7d1648 > test/integration/smoke/test_vm_life_cycle.py 1386830 > > Diff: https://reviews.apache.org/r/24298/diff/ > > > Testing > ------- > > Yes, tested test_vm_life_cycle.py with python command. > > > Thanks, > > Gaurav Aradhye > >
