Pierre-Luc, I plan to apply Kishan's comment and add it to 4.4.1 On Tue, Aug 5, 2014 at 2:13 PM, Pierre-Luc Dion <pd...@cloudops.com> wrote: > Will this be part of 4.4.1 ? if so, we will have to update Release-notes for > upgrade steps from 4.2.x to 4.4 which for the moment use the template named > systemvm-<hypervisor>-4.3. > > Thanks, > > > Pierre-Luc DION > Architecte de Solution Cloud | Cloud Solutions Architect > t 855.652.5683 > > CloudOps Votre partenaire infonuagique | Cloud Solutions Experts > 420 rue Guy | Montreal | Quebec | H3J 1S6 > w cloudops.com | tw @CloudOps_ > > > > On Tue, Aug 5, 2014 at 6:43 AM, Kishan Kavala <kishan.kav...@citrix.com> > wrote: >> >> >> >> > On Aug. 5, 2014, 4:12 p.m., Kishan Kavala wrote: >> > > Daan, >> > > This looks good to me. >> > > Can you also please remove template upgrade code in >> > > Upgrade421to430.java. Otherwise upgrades from 4.2 will fail complaining >> > > that >> > > systemvm-xenserver-4.3 is not available. >> >> I mean systemvm-<hypervisor>-4.3 template, not just xen >> >> >> - Kishan >> >> >> ----------------------------------------------------------- >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/24229/#review49584 >> ----------------------------------------------------------- >> >> >> On Aug. 4, 2014, 5:53 p.m., daan Hoogland wrote: >> > >> > ----------------------------------------------------------- >> >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/24229/ >> > ----------------------------------------------------------- >> > >> > (Updated Aug. 4, 2014, 5:53 p.m.) >> >> > >> > >> > Review request for cloudstack, Abhinandan Prateek and Kishan Kavala. >> > >> > >> > Repository: cloudstack-git >> > >> > >> > Description >> > ------- >> >> > >> > upgrade code for templates in 4.4.x due to java upgrade >> > >> > >> > Diffs >> > ----- >> > >> > engine/schema/src/com/cloud/upgrade/dao/Upgrade440to441.java 497da8d >> > >> > Diff: https://reviews.apache.org/r/24229/diff/ >> > >> > >> > Testing >> > ------- >> > >> > sugestions welcome >> > >> > >> > Thanks, >> > >> > daan Hoogland >> > >> > >> >
-- Daan