----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24185/#review49353 -----------------------------------------------------------
Ship it! Ship It! - Santhosh Edukulla On Aug. 1, 2014, 4:23 p.m., Gaurav Aradhye wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24185/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2014, 4:23 p.m.) > > > Review request for cloudstack and Santhosh Edukulla. > > > Bugs: CLOUDSTACK-7224 > https://issues.apache.org/jira/browse/CLOUDSTACK-7224 > > > Repository: cloudstack-git > > > Description > ------- > > ResponseType is not passed from asyncJobMgr to marvinRequest function, only > command is passed. In this case responseType parameter should not be set as > mandatory in marvinReqest. Make it optional. > > Also remove connection.close() , as there is no close method for > cloudstackConnection. Closing the connection is not required as the copy of > cloudstackConnection which is created for every worker thread will be deleted > once it goes out of scope. > > > Diffs > ----- > > tools/marvin/marvin/asyncJobMgr.py 00e8c19 > tools/marvin/marvin/cloudstackConnection.py a8c35f6 > > Diff: https://reviews.apache.org/r/24185/diff/ > > > Testing > ------- > > Test perform concurrent snapshots and migrate the vm from one host ... === > TestName: test_01_concurrent_snapshots_live_migrate | Status : SUCCESS === > ok > Test stop running VM while performing concurrent snapshot on volume ... SKIP: > skip > Test while parent concurrent snapshot job in progress,create ... SKIP: skip > Test while parent concurrent snapshot job in progress,create volume ... SKIP: > skip > > ---------------------------------------------------------------------- > Ran 4 tests in 201.910s > > OK (SKIP=3) > > > Thanks, > > Gaurav Aradhye > >
